make grpcPodConfig.extractContent.cacheDir an optional field #421
Conversation
openshift-merge-robot
added
the
needs-rebase
openshift-ci
bot
added
the
approved
openshift-merge-robot
removed
the
needs-rebase
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #421 +/- ##
=======================================
Coverage 39.79% 39.79%
=======================================
Files 56 56
Lines 5450 5450
=======================================
Hits 2169 2169
Misses 3127 3127
Partials 154 154 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| - catalogDir | ||
| properties: | ||
| cacheDir: | ||
| description: CacheDir is the directory storing the pre-calculated API cache. | ||
| description: CacheDir is the (optional) directory storing the pre-calculated API cache. |
There was a problem hiding this comment.
Won’t we need to update all the places that use it to ensure the value is set when it isn’t provided?
There was a problem hiding this comment.
The oddity of the o-f/api repo is that its testing is really in other repos. Testing for this is in operator-framework/operator-lifecycle-manager#3556
There was a problem hiding this comment.
Hi @grokspawn
We need to ensure that in other places we always check if the value exists before doing something, but as discussed in : https://kubernetes.slack.com/archives/C0181L6JYQ2/p1745505793756289?thread_ts=1745505180.270419&cid=C0181L6JYQ2 I do not see harm either, nothing beyond to that.
So, /lgtm
/approve
|
Contributes to operator-framework/operator-lifecycle-manager/issues/3257 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: acornett21, camilamacedo86, grokspawn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
openshift-merge-bot
bot
merged commit 436783b
into
operator-framework:master
No description provided.