Skip to content

make grpcPodConfig.extractContent.cacheDir an optional field #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2025
Merged

make grpcPodConfig.extractContent.cacheDir an optional field #421

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions crds/operators.coreos.com_catalogsources.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -975,11 +975,10 @@ spec:
configured to use *must* be using the file-based catalogs in order to utilize this feature.
type: object
required:
- cacheDir
- catalogDir
properties:
cacheDir:
description: CacheDir is the directory storing the pre-calculated API cache.
description: CacheDir is the (optional) directory storing the pre-calculated API cache.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won’t we need to update all the places that use it to ensure the value is set when it isn’t provided?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The oddity of the o-f/api repo is that its testing is really in other repos. Testing for this is in operator-framework/operator-lifecycle-manager#3556

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @grokspawn

We need to ensure that in other places we always check if the value exists before doing something, but as discussed in : https://kubernetes.slack.com/archives/C0181L6JYQ2/p1745505793756289?thread_ts=1745505180.270419&cid=C0181L6JYQ2 I do not see harm either, nothing beyond to that.

So, /lgtm
/approve

type: string
catalogDir:
description: CatalogDir is the directory storing the file-based catalog contents.
Expand Down
Loading