✨ Add registry+v1 bundle validation framework #1885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1885 +/- ##
==========================================
+ Coverage 68.98% 69.20% +0.21%
==========================================
Files 66 67 +1
Lines 5243 5302 +59
==========================================
+ Hits 3617 3669 +52
- Misses 1395 1400 +5
- Partials 231 233 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
perdasilva
force-pushed
the
bundle-validation
branch
4 times, most recently
from
11d453f to
2af24e8
Compare
perdasilva
force-pushed
the
bundle-validation
branch
from
2af24e8 to
87717a5
Compare
thetechnick
previously approved these changes
Apr 1, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
perdasilva
force-pushed
the
bundle-validation
branch
from
87717a5 to
923b325
Compare
added 2 commits
April 4, 2025 10:55
Signed-off-by: Per Goncalves da Silva <[email protected]>
Signed-off-by: Per Goncalves da Silva <[email protected]>
perdasilva
force-pushed
the
bundle-validation
branch
from
923b325 to
0c37d4a
Compare
thetechnick
reviewed
Apr 4, 2025
Signed-off-by: Per Goncalves da Silva <[email protected]>
perdasilva
force-pushed
the
bundle-validation
branch
from
0c37d4a to
45b1610
Compare
thetechnick
approved these changes
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #1883 #1884
Adds a small registry+v1 bundle validation framework composed of individual validation functions. It is extensible by adding new validation functions. Note that the validation framework is not currently used. This will happen in a follow up PR because some refactoring will be needed of the convert/rukpak package and I didn't want to bloat the PR.
Reviewer Checklist