oracle_opatch: Find running listener more robust #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ut content, dependencies, and UPI (unique patch ID) differ. These patches have to be rolled back in advance of applying the PSU/RU and must afterwards be installed with the correct version (=UPI). They should however not be rolled back if they are already there with the desired UPI. This helps to write more idempotent playbooks. So there is a new parameter exclude_upi that is evaluated only if state=absent. To keep changes in working code at a minimum the check for UPI could be acquired only by another "opatch lspatches" that costs some seconds.
Oracle_opatch searches the running listener with: ```ps -elf | grep "[0-9] $ORACLE_HOME/bin/tnslsnr"``` ...then splits the line by spaces and takes the last but one field. This does not work for a "ps -ef" result like this: ```0 S oracle 16921 1 0 80 0 - 43851 ep_pol 21:58 ? 00:00:00 /u01/app/oracle/product/12.1.0.2/ee/bin/tnslsnr LISTENER /dev/null -inherit``` In this case "linelist[-2]" deliveres "/dev/null" instead of the LISTENER name. My fix is to search the ps line for the listener executable and use the next field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should contain commit 42e65ec only. But it includes other unrelated commits.
This is the commit message:
Oracle_opatch searches the running listener with:
ps -elf | grep "[0-9] $ORACLE_HOME/bin/tnslsnr"...then splits the line by spaces and takes the last but one field.
This does not work for a "ps -ef" result like this:
0 S oracle 16921 1 0 80 0 - 43851 ep_pol 21:58 ? 00:00:00 /u01/app/oracle/product/12.1.0.2/ee/bin/tnslsnr LISTENER /dev/null -inheritIn this case "linelist[-2]" deliveres "/dev/null" instead of the LISTENER
name. My fix is to search the ps line for the listener executable and use
the next field.