Flex: Add support for configuring table indexes in the Lua config #1847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lonvia
reviewed
Dec 7, 2022
|
|
||
| std::string columns() const; | ||
|
|
||
| void set_columns(std::string const &columns) |
There was a problem hiding this comment.
That's rather 'add_column'?
There was a problem hiding this comment.
This is not intended for adding columns one at a time, but an overload of the void set_columns(std::vector<std::string> const &columns) function so that we don't have to create a vector if all we want is to add a single column.
The table definitions have a new (optional) field called "indexes" now which takes a list of index definitions. If the field is not there, we fall back to what we did before, a GIST index on the only/first geometry column of table is created. To disable indexes, set to an empty array. See the flex-config/indexes.lua Lua config for some usage examples. See osm2pgsql-dev#1780
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The table definitions have a new (optional) field called "indexes" now which takes a list of index definitions. If the field is not there, we fall back to what we did before, a GIST index on the only/first geometry column of table is created. To disable indexes, set to an empty array.
See the flex-config/indexes.lua Lua config for some usage examples.
See #1780