fix: use same UNC path normalization logic with libuv#306
Merged
Boshen merged 9 commits intooxc-project:mainfrom Nov 13, 2024
Merged
Conversation
sapphi-red
commented
Nov 12, 2024
Member
|
Requesting @Brooooooklyn because I don't know anything about windows. |
CodSpeed Performance ReportMerging #306 will not alter performanceComparing Summary
|
Member
|
@sapphi-red Please wait a moment while I verify if this custom canonicalize implementation is truly optimized on Windows |
Member
Author
|
@Brooooooklyn It seems After (with sapphi-red#1) |
Member
Me too, It seems that we can simply use |
Member
Author
|
I reverted some code to use |
Member
|
Please let me know when ready to merge. |
Brooooooklyn
approved these changes
Nov 13, 2024
Member
Author
|
It's ready to merge 👍 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #295