Add Sr ion#68
Merged
johannes-moegerle merged 4 commits intoJul 13, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds strontium ion (Sr⁺) as a supported species in rydstate.species by introducing element properties, SQDT/NIST level data, and potential models, while also updating/removing some nuclear dipole constants for existing Sr/Yb isotopes.
Changes:
- Added a new
strontium_ionspecies package (element properties, SQDT + NIST data, and potentials) and exported it viarydstate.species. - Updated nuclear dipole moments for Sr-87 / Yb-171 / Yb-173 and removed nuclear dipole definitions for spin-0 isotopes (Sr-88 / Yb-174).
- Removed the (previously available) Marinescu-1994 strontium neutral potential classes/exports.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/rydstate/species/ytterbium/element_properties_data.py | Updates Yb-171/Yb-173 nuclear dipole constants; removes Yb-174 nuclear_dipole definition. |
| src/rydstate/species/ytterbium_ion/element_properties_data.py | Updates Yb⁺-171/Yb⁺-173 nuclear dipole constants; removes Yb⁺-174 nuclear_dipole definition. |
| src/rydstate/species/strontium/potential_data.py | Removes Marinescu-1994 strontium neutral potential definitions; keeps Coulomb + Fei-2009. |
| src/rydstate/species/strontium/element_properties_data.py | Updates Sr-87 nuclear dipole constant; removes Sr-88 nuclear_dipole definition. |
| src/rydstate/species/strontium/init.py | Stops exporting removed Marinescu-1994 strontium neutral potentials. |
| src/rydstate/species/strontium_ion/sqdt_data.py | New: Sr⁺ SQDT definitions referencing a bundled NIST levels file. |
| src/rydstate/species/strontium_ion/potential_data.py | New: Sr⁺ Coulomb and Marinescu-1994 potentials. |
| src/rydstate/species/strontium_ion/nist_data.txt | New: Tab-delimited NIST energy level dataset for Sr⁺. |
| src/rydstate/species/strontium_ion/element_properties_data.py | New: Sr⁺ element properties for Sr-87 and Sr-88 isotopes. |
| src/rydstate/species/strontium_ion/init.py | New: Exports Sr⁺ element properties, SQDT, and potential classes. |
| src/rydstate/species/init.py | Registers/exports the new strontium_ion species package. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
johannes-moegerle
force-pushed
the
add-sr-ion
branch
from
July 13, 2026 10:03
c0d5a85 to
777adb2
Compare
johannes-moegerle
force-pushed
the
add-sr-ion
branch
from
July 13, 2026 10:18
777adb2 to
34a9e95
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.