Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alerts Redesign #1101

Merged
merged 6 commits into from
Jan 30, 2025
Merged

Alerts Redesign #1101

merged 6 commits into from
Jan 30, 2025

Conversation

parmesant
Copy link
Contributor

Fixes #XXXX.

Description


This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@parmesant parmesant force-pushed the alerts-redesign-branch branch from 22090c2 to 61be3e6 Compare January 14, 2025 04:24
@coveralls
Copy link

coveralls commented Jan 14, 2025

Pull Request Test Coverage Report for Build 13029132044

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 969 (0.0%) changed or added relevant lines in 11 files are covered.
  • 11 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-1.3%) to 11.67%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/rbac/role.rs 0 3 0.0%
src/query/mod.rs 0 7 0.0%
src/handlers/http/modal/query_server.rs 0 10 0.0%
src/storage/localfs.rs 0 11 0.0%
src/storage/object_storage.rs 0 20 0.0%
src/handlers/http/modal/server.rs 0 35 0.0%
src/sync.rs 0 46 0.0%
src/alerts/target.rs 0 77 0.0%
src/handlers/http/alerts.rs 0 97 0.0%
src/alerts/alerts_utils.rs 0 263 0.0%
Files with Coverage Reduction New Missed Lines %
src/alerts/mod.rs 1 0.0%
src/metadata.rs 1 1.47%
src/event/mod.rs 1 0.0%
src/storage/object_storage.rs 2 0.0%
src/rbac/role.rs 2 0.0%
src/alerts/target.rs 4 0.0%
Totals Coverage Status
Change from base Build 13006822034: -1.3%
Covered Lines: 2232
Relevant Lines: 19126

💛 - Coveralls

@parmesant parmesant force-pushed the alerts-redesign-branch branch 5 times, most recently from 38cd6d8 to b484380 Compare January 17, 2025 16:31
@parmesant parmesant force-pushed the alerts-redesign-branch branch 4 times, most recently from d0c9ad8 to 065bfa5 Compare January 24, 2025 06:10
@parmesant parmesant force-pushed the alerts-redesign-branch branch from 990d58e to 571de5c Compare January 27, 2025 15:46
@parmesant parmesant force-pushed the alerts-redesign-branch branch from 571de5c to cab2dfa Compare January 27, 2025 15:52
@de-sh de-sh mentioned this pull request Jan 30, 2025
3 tasks
@nitisht nitisht merged commit 11a6378 into parseablehq:main Jan 30, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants