Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mail): refactor email service loading and docs #96

Open
wants to merge 3 commits into
base: development
Choose a base branch
from

Conversation

mariogarcia
Copy link
Contributor

@mariogarcia mariogarcia commented Jul 8, 2020

Before getting started

Update the new email schema configuration from application.yml.template. Email configuration structure has changed.

Testing steps

  • check tests passed
  • check removing all email configuration. Scheduling service should still work and print out some traces
  • check adding only email related configuration only
  • check changing email -> disabled configuration only. You should see DummyEmailService logs
  • add aws credential information. Now scheduling service should be using AWS email service.
  • check changing email -> disabled and see how AWS service works in disabled mode
  • High five!

@mariogarcia mariogarcia force-pushed the refactor/configuration branch from 122cb5a to aac0618 Compare July 8, 2020 04:18
@mariogarcia mariogarcia force-pushed the refactor/configuration branch from aac0618 to 21c3453 Compare July 9, 2020 03:36
@mariogarcia mariogarcia changed the title WIP: feat(mail): refactor email service loading and docs feat(mail): refactor email service loading and docs Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants