Fix/junction and test helper bugs - #7
Open
ViezeVingertjes wants to merge 3 commits into
Open
ViezeVingertjes wants to merge 3 commits into
ViezeVingertjes wants to merge 3 commits into
Conversation
The horizontal branch of updateCompactRegions linked neighbor slots with compactUp (always nil) instead of the shared compact strip.
Input pads now use the normal region state instead of atRandom on every read, so highlights and simulation stay consistent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updateCompactRegionsfor horizontally adjacent junctions. Shared strips were linked viacompactUp(always nil) instead of the correct left/right compact regions.currentStatefromChDGeneratorRegion. Input pads now use normal stored region state, so highlights and simulation stay consistent.Each fix includes a regression test (
ChDHorizontalCompactRegionTest,ChDAreaTest>>#testAddPAtSetsPSilicon,ChDAreaInputRegionsTest>>#testInputRegionCurrentStateReflectsStoredValue).