Disable fetch wal-method for pg_basebackup with Percona features #533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As it may clash with encrypted WAL streaming. Hide the fetch option from the usage output and throw an error if it is used.
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (82.08%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## TDE_REL_17_STABLE #533 +/- ##
==================================================
Coverage 82.08% 82.08%
==================================================
Files 25 25
Lines 3170 3170
Branches 505 505
==================================================
Hits 2602 2602
Misses 460 460
Partials 108 108
🚀 New features to boost your workflow:
|
|
Are we sure we want to change these tools for people running our distribution without wal encryption turned on? I'm not convinced that's what we want to do. |
|
Yes, I think we can abandon this idea after the introduction of --encrypt-wal flag |
|
Seems like having just the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it may clash with encrypted WAL streaming.
Hide the fetch option from the usage output and throw an error if it is used.