Skip to content

Disable fetch wal-method for pg_basebackup with Percona features #533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Disable fetch wal-method for pg_basebackup with Percona features #533

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/bin/pg_basebackup/pg_basebackup.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,6 +396,12 @@ tablespace_list_append(const char *arg)
static void
usage(void)
{
#ifdef PERCONA_EXT
#define WAL_METHODS "none|stream"
#else
#define WAL_METHODS "none|fetch|stream"
#endif

printf(_("%s takes a base backup of a running PostgreSQL server.\n\n"),
progname);
printf(_("Usage:\n"));
Expand All @@ -414,7 +420,7 @@ usage(void)
printf(_(" -T, --tablespace-mapping=OLDDIR=NEWDIR\n"
" relocate tablespace in OLDDIR to NEWDIR\n"));
printf(_(" --waldir=WALDIR location for the write-ahead log directory\n"));
printf(_(" -X, --wal-method=none|fetch|stream\n"
printf(_(" -X, --wal-method=" WAL_METHODS "\n"
" include required WAL files with specified method\n"));
printf(_(" -z, --gzip compress tar output\n"));
printf(_(" -Z, --compress=[{client|server}-]METHOD[:DETAIL]\n"
Expand Down Expand Up @@ -2549,6 +2555,9 @@ main(int argc, char **argv)
else if (strcmp(optarg, "f") == 0 ||
strcmp(optarg, "fetch") == 0)
{
#ifdef PERCONA_EXT
pg_fatal("\"fetch\" wal-method is not supported with Percona features, must be \"stream\" or \"none\"");
#endif
includewal = FETCH_WAL;
}
else if (strcmp(optarg, "s") == 0 ||
Expand Down
Loading