build: fix c-lint checks with bits/xxx includes #1903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We never want to directly include bits/xxx include files, so remove this cppcheck workaround. Working backward from there we need to guard against a cppcheck bug in the way it expands glibs headers instead - and we can't do this in a way that requires updating for every Fedora release, its too obscure (caused wasted time for several folk). So, in the end, simplify the script a bunch and see how we go ...
natoscott
force-pushed
the
fix-rawhide-f40-ci
branch
from
e53656e to
c176e20
Compare
More and more workarounds have been added to cppcheck misfirings to the point that we've decided to drop it in favour of the other static checkers, which seem to pickup far more interesting issues anyway (Coverity Scan, GitHub CodeQL).
natoscott
force-pushed
the
fix-rawhide-f40-ci
branch
from
c176e20 to
fc819be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We never want to directly include bits/xxx include files, so remove this cppcheck workaround. Working backward from there we need to guard against a cppcheck bug in the way it expands glibs headers instead - and we can't do this in a way that requires updating for every Fedora release, its too obscure (caused wasted time for several folk). So, in the end, simplify the script a bunch and see how we go ...