performancecopilot · natoscott · Feb 29, 2024 · Feb 28, 2024 · Feb 28, 2024
diff --git a/scripts/c-lint b/scripts/c-lint
diff --git a/src/autofsd-probe/GNUmakefile b/src/autofsd-probe/GNUmakefile
@@ -43,8 +43,5 @@ default_pcp : default
 
 install_pcp : install
 
-check::	$(CFILES)
-	$(CLINT) $^
-
 check :: $(MAN_PAGES)
 	$(MANLINT) $^
diff --git a/src/collectl2pcp/GNUmakefile b/src/collectl2pcp/GNUmakefile
@@ -46,6 +46,3 @@ default_pcp:    default
 install_pcp:    install
 
 collectl2pcp.o:	$(TOPDIR)/src/include/pcp/libpcp.h
-
-check::	$(CFILES) $(HFILES)
-	$(CLINT) $^
diff --git a/src/dbpmda/src/GNUmakefile b/src/dbpmda/src/GNUmakefile
@@ -49,6 +49,3 @@ default_pcp:	default
 install_pcp:	install
 
 $(OBJECTS):	$(TOPDIR)/src/include/pcp/libpcp.h
-
-check::	$(CFILES) $(HFILES)
-	$(CLINT) $^
diff --git a/src/find-filter/GNUmakefile b/src/find-filter/GNUmakefile
@@ -29,6 +29,3 @@ install:	default
 default_pcp:	default
 
 install_pcp:	install
-
-check:: $(CFILES)
-	$(CLINT) $^
diff --git a/src/include/builddefs.in b/src/include/builddefs.in
@@ -183,7 +183,6 @@ LN_S	= @LN_S@
 GREP    = @grep@
 GIT	= @GIT@
 MANLINT	= $(TOPDIR)/scripts/man-lint
-CLINT	= $(TOPDIR)/scripts/c-lint -I$(TOPDIR)/src/include/pcp
 PYLINT	= @PYLINT@ --rcfile=$(TOPDIR)/.pylintrc --output-format=colorized
 PYTHON	= @PYTHON@
 PYTHON3	= @PYTHON3@

diff --git a/src/libpcp/src/GNUmakefile b/src/libpcp/src/GNUmakefile
@@ -197,6 +197,3 @@ $(LIBCONFIG): $(LIBCONFIG).in
 endif
 
 $(OBJECTS):	$(TOPDIR)/src/include/pcp/libpcp.h $(JSONSL_XFILES)
-
-check::	$(CFILES) $(HFILES)
-	$(CLINT) $^
diff --git a/src/libpcp_archive/src/GNUmakefile b/src/libpcp_archive/src/GNUmakefile
@@ -84,6 +84,3 @@ $(LIBCONFIG): $(LIBCONFIG).in
 endif
 
 $(OBJECTS):	$(TOPDIR)/src/include/pcp/archive.h
-
-check:: $(CFILES) $(HFILES)
-	$(CLINT) $^
diff --git a/src/libpcp_gui/src/GNUmakefile b/src/libpcp_gui/src/GNUmakefile
@@ -74,6 +74,3 @@ $(LIBTARGET): $(VERSION_SCRIPT)
 endif
 
 $(OBJECTS):	$(TOPDIR)/src/include/pcp/libpcp.h
-
-check:: $(CFILES)
-	$(CLINT) $^
diff --git a/src/libpcp_import/src/GNUmakefile b/src/libpcp_import/src/GNUmakefile
@@ -88,6 +88,3 @@ domain.h: $(TOPDIR)/src/pmns/stdpmid
 	$(DOMAIN_MAKERULE)
 
 $(OBJECTS):	$(TOPDIR)/src/include/pcp/libpcp.h
-
-check:: $(CFILES) $(HFILES)
-	$(CLINT) $^
diff --git a/src/libpcp_mmv/src/GNUmakefile b/src/libpcp_mmv/src/GNUmakefile
@@ -72,6 +72,3 @@ $(LIBTARGET): $(VERSION_SCRIPT)
 endif
 
 mmv_stats.o:	$(TOPDIR)/src/include/pcp/libpcp.h
-
-check:: $(CFILES)
-	$(CLINT) $^
diff --git a/src/libpcp_pmcd/src/GNUmakefile b/src/libpcp_pmcd/src/GNUmakefile
@@ -84,6 +84,3 @@ default_pcp : default
 install_pcp : install
 
 client.o:	$(TOPDIR)/src/include/pcp/libpcp.h
-
-check::	$(CFILES)
-	$(CLINT) $^
diff --git a/src/libpcp_pmda/src/GNUmakefile b/src/libpcp_pmda/src/GNUmakefile
@@ -93,6 +93,3 @@ $(LIBCONFIG): $(LIBCONFIG).in
 endif
 
 $(OBJECTS):	$(TOPDIR)/src/include/pcp/libpcp.h
-
-check::	$(CFILES) $(HFILES) $(XFILES)
-	$(CLINT) $^
diff --git a/src/libpcp_web/src/GNUmakefile b/src/libpcp_web/src/GNUmakefile
@@ -154,15 +154,3 @@ discover.o:	discover.h discover.c
 http_parser.o:	http_parser.c http_parser.h
 query.o:	query.h query.c query_parser.y
 http_client.o load.o query.o:	$(TOPDIR)/src/include/pcp/libpcp.h
-
-# last 3 suppressions added for (busted?) cppcheck in Fedora 38 and 39
-# circa Jan 2024 - Ken
-#
-check:: $(CFILES) $(HFILES) $(XFILES)
-	$(CLINT) \
-	  --suppress=unknownMacro:/usr/include/bits/stdlib.h \
-	  --suppress=internalAstError:deps/hiredis-cluster/command.c:351 \
-	  --suppress=va_list_usedBeforeStarted:deps/hiredis/hiredis.c:394 \
-	  --suppress=syntaxError:deps/hiredis/sds.c:1280 \
-	  --suppress=invalidLifetime:deps/hiredis/read.c:337 \
-	  $^
diff --git a/src/newhelp/GNUmakefile b/src/newhelp/GNUmakefile
@@ -54,6 +54,3 @@ default_pcp:	default
 install_pcp:	install
 
 chkhelp.o newhelp.o:	$(TOPDIR)/src/include/pcp/libpcp.h
-
-check:: $(CFILES)
-	$(CLINT) $^
diff --git a/src/pcp/atop/GNUmakefile b/src/pcp/atop/GNUmakefile
@@ -116,9 +116,5 @@ gpucom.o:	gpumetrics.h
 
 atop.o atopsar.o various.o:	$(TOPDIR)/src/include/pcp/libpcp.h
 
-check::	$(CFILES) $(HFILES)
-	#$(CLINT) $^
-	#disabled due to https://bugzilla.redhat.com/show_bug.cgi?id=2056773
-
 check::	$(MAN_PAGES)
 	$(MANLINT) $^
diff --git a/src/pcp/htop/GNUmakefile b/src/pcp/htop/GNUmakefile
@@ -281,17 +281,5 @@ $(MAN_PAGES): $(CMDTARGET).1.in $(CMDTARGET).5.in
 		-e 's;pcp/pcp;pcp;g'; \
 	done
 
-# suppressions added for (busted?) cppcheck in Fedora 38 and 39
-# circa Jan 2024 - Ken
-#
-check::	$(CFILES) $(HFILES)
-	$(CLINT) \
-	    --suppress=unknownMacro:Action.c \
-	    --suppress=unknownMacro:CommandLine.c \
-	    --suppress=unknownMacro:CRT.c \
-	    --suppress=syntaxError:RowField.h \
-	    --suppress=syntaxError:Meter.c \
-	$^
-
 check::	$(MAN_PAGES)
 	$(MANLINT) $^
diff --git a/src/pmcd/src/GNUmakefile b/src/pmcd/src/GNUmakefile
@@ -44,7 +44,3 @@ install_pcp:	install
 $(OBJECTS):	$(HFILES)
 
 $(OBJECTS):	$(TOPDIR)/src/include/pcp/libpcp.h
-
-check:: $(CFILES) $(HFILES)
-	$(CLINT) $^
-
diff --git a/src/pmcd_wait/GNUmakefile b/src/pmcd_wait/GNUmakefile
@@ -31,6 +31,3 @@ default_pcp:	default
 install_pcp:	install
 
 pmcd_wait.o:	$(TOPDIR)/src/include/pcp/libpcp.h
-
-check:: $(CFILES)
-	$(CLINT) $^
diff --git a/src/pmclient/GNUmakefile b/src/pmclient/GNUmakefile
@@ -61,6 +61,5 @@ install_pcp:	install
 
 pmclient.o pmclient_fg.o:	$(TOPDIR)/src/include/pcp/libpcp.h
 
-check::	$(CFILES)
-	$(CLINT) $(CFILES)
+check:: $(PYFILES)
 	$(PYLINT) $(PYFILES)
diff --git a/src/pmcpp/GNUmakefile b/src/pmcpp/GNUmakefile
@@ -44,6 +44,3 @@ install_pcp:	install
 
 pmcpp.static$(EXECSUFFIX):	$(CFILES) $(STATIC_LIBPCP)
 	$(CCF) -DPCP_STATIC -o $@ $(LDFLAGS) $(CFILES) $(STATIC_LIBPCP) $(STATIC_LDLIBS)
-
-check::	$(CFILES)
-	$(CLINT) $^
diff --git a/src/pmdas/bpf/GNUmakefile b/src/pmdas/bpf/GNUmakefile
@@ -55,9 +55,6 @@ domain.h: ../../pmns/stdpmid
 pmns:
 	$(LN_S) -f root_bpf pmns
 
-check::	$(CFILES)
-	$(CLINT) $^
-
 check:: $(MAN_PAGES)
 	$(MANLINT) $^
 

diff --git a/src/pmdas/denki/GNUmakefile b/src/pmdas/denki/GNUmakefile
@@ -70,8 +70,5 @@ $(OBJECTS): domain.h
 pmda.o: $(VERSION_SCRIPT)
 pmda.o:	$(TOPDIR)/src/include/pcp/libpcp.h
 
-check:: $(CFILES)
-	$(CLINT) $^
-
 check:: $(MAN_PAGES)
 	$(MANLINT) $^
diff --git a/src/pmdas/farm/GNUmakefile b/src/pmdas/farm/GNUmakefile
@@ -68,9 +68,6 @@ $(VERSION_SCRIPT):
 domain.h: ../../pmns/stdpmid
 	$(DOMAIN_MAKERULE)
 
-check:: $(CFILES) $(HFILES)
-	$(CLINT) $^
-
 pmda.o:			pmdafarm.h
 pmda.o farm_stats.o:	farm_stats.h
 

diff --git a/src/pmdas/linux/GNUmakefile b/src/pmdas/linux/GNUmakefile
@@ -125,9 +125,6 @@ domain.h: ../../pmns/stdpmid
 $(CONFTARGETS):	mk.rewrite
 	CPP="$(CPP)" INCDIR="$(TOPDIR)/src/include" ./mk.rewrite
 
-check:: $(CFILES) $(HFILES)
-	$(CLINT) $^
-
 proc_interrupts.o pmda.o proc_partitions.o:	linux.h
 numa_meminfo.o proc_cpuinfo.o proc_stat.o:	linux.h
 filesys.o proc_interrupts.o pmda.o:	filesys.h

diff --git a/src/pmdas/linux_proc/GNUmakefile b/src/pmdas/linux_proc/GNUmakefile
@@ -122,8 +122,5 @@ pmda.o:	$(VERSION_SCRIPT)
 
 acct.o cgroups.o contexts.o pmda.o proc_dynamic.o proc_pid.o:	$(TOPDIR)/src/include/pcp/libpcp.h
 
-check::	$(CFILES) $(HFILES)
-	$(CLINT) $^
-
 check:: $(MAN_PAGES)
 	$(MANLINT) $^
diff --git a/src/pmdas/linux_sockets/GNUmakefile b/src/pmdas/linux_sockets/GNUmakefile
@@ -76,8 +76,5 @@ $(OBJECTS): domain.h ss_stats.h
 pmda.o: $(TOPDIR)/src/include/pcp/libpcp.h
 pmda.o: $(VERSION_SCRIPT)
 
-check:: $(CFILES) $(HFILES)
-	$(CLINT) $^
-
 check:: $(MAN_PAGES)
 	$(MANLINT) $^
diff --git a/src/pmdas/linux_xfs/GNUmakefile b/src/pmdas/linux_xfs/GNUmakefile
@@ -87,8 +87,5 @@ pmda.o: $(VERSION_SCRIPT)
 
 pmda.o:	$(TOPDIR)/src/include/pcp/libpcp.h
 
-check:: $(CFILES) $(HFILES)
-	$(CLINT) $^
-
 check:: $(MAN_PAGES)
 	$(MANLINT) $^
diff --git a/src/pmdas/linux_zfs/GNUmakefile b/src/pmdas/linux_zfs/GNUmakefile
@@ -72,8 +72,5 @@ pmda.o: $(VERSION_SCRIPT)
 
 pmda.o:	$(TOPDIR)/src/include/pcp/libpcp.h
 
-check:: $(CFILES) $(HFILES)
-	$(CLINT) $^
-
 check:: $(MAN_PAGES)
 	$(MANLINT) $^
diff --git a/src/pmdas/mmv/src/GNUmakefile b/src/pmdas/mmv/src/GNUmakefile
@@ -60,6 +60,3 @@ pmns:
 	$(LN_S) -f root_mmv pmns
 
 mmv.o:	$(TOPDIR)/src/include/pcp/libpcp.h
-
-check::	$(CFILES)
-	$(CLINT) $^
diff --git a/src/pmdas/perfevent/GNUmakefile b/src/pmdas/perfevent/GNUmakefile
@@ -77,6 +77,3 @@ perfalloc: perfalloc.o perflock.o
 
 clean clobber::
 	$(RM) configparser.yy.c perfalloc perfalloc.o
-
-check:: $(CFILES) $(HFILES)
-	$(CLINT) $^
diff --git a/src/pmdas/pmcd/src/GNUmakefile b/src/pmdas/pmcd/src/GNUmakefile
@@ -78,6 +78,3 @@ $(VERSION_SCRIPT):
 $(LIBTARGET): $(VERSION_SCRIPT)
 
 pmcd.o:	$(TOPDIR)/src/include/pcp/libpcp.h
-
-check:: $(CFILES) $(HFILES)
-	$(CLINT) $^
diff --git a/src/pmdas/podman/GNUmakefile b/src/pmdas/podman/GNUmakefile
@@ -80,8 +80,5 @@ pmda.o: $(VERSION_SCRIPT)
 pmda.o:	$(TOPDIR)/src/include/pcp/libpcp.h
 podman.o: $(JSONSL_HFILES)
 
-check:: $(CFILES) $(HFILES)
-	$(CLINT) $^
-
 check:: $(MAN_PAGES)
 	$(MANLINT) $^
diff --git a/src/pmdas/resctrl/GNUmakefile b/src/pmdas/resctrl/GNUmakefile
@@ -70,8 +70,5 @@ resctrl.o: $(VERSION_SCRIPT)
 
 resctrl.o: $(TOPDIR)/src/include/pcp/libpcp.h
 
-check:: $(CFILES) $(HFILES)
-	$(CLINT) $^
-
 check:: $(MAN_PAGES)
 	$(MANLINT) $^
diff --git a/src/pmdas/root/GNUmakefile b/src/pmdas/root/GNUmakefile
@@ -84,6 +84,3 @@ pmns :
 
 lxc.o root.o:	$(TOPDIR)/src/include/pcp/libpcp.h
 podman.o:	$(JSONSL_HFILES)
-
-check:: $(CFILES) $(HFILES)
-	$(CLINT) $^
diff --git a/src/pmdas/statsd/src/GNUmakefile b/src/pmdas/statsd/src/GNUmakefile
@@ -99,6 +99,3 @@ $(VERSION_SCRIPT):
 
 domain.h: $(TOPDIR)/src/pmns/stdpmid
 	$(DOMAIN_MAKERULE)
-
-check:: $(CFILES) $(HFILES)
-	$(CLINT) $^
diff --git a/src/pmerr/GNUmakefile b/src/pmerr/GNUmakefile
@@ -31,6 +31,3 @@ default_pcp:	default
 install_pcp:	install
 
 pmerr.o:	$(TOPDIR)/src/include/pcp/pmapi.h
-
-check::	$(CFILES)
-	$(CLINT) $^
diff --git a/src/pmfind/GNUmakefile b/src/pmfind/GNUmakefile
@@ -71,6 +71,3 @@ pmfind.service : pmfind.service.in
 
 crontab: crontab.in
 	$(SED) -e 's;@user@;'$(CRONTAB_USER)';' -e 's;@path@;'$(PCP_BINADM_DIR)';g' $< > $@
-
-check:: $(CFILES)
-	$(CLINT) $^
diff --git a/src/pmhostname/GNUmakefile b/src/pmhostname/GNUmakefile
@@ -31,6 +31,3 @@ default_pcp:	default
 install_pcp:	install
 
 pmhostname.o:	$(TOPDIR)/src/include/pcp/libpcp.h
-
-check::	$(CFILES)
-	$(CLINT) $^
diff --git a/src/pmie/src/GNUmakefile b/src/pmie/src/GNUmakefile
@@ -84,6 +84,3 @@ $(OBJECTS):	$(TOPDIR)/src/include/pcp/libpcp.h
 
 $(DUMPER)$(EXECSUFFIX):	$(DUMPER).c
 	$(CCF) -o $@ $(DUMPER).c $(LDFLAGS) $(LDLIBS)
-
-check::	$(CFILES) $(HFILES)
-	$(CLINT) $^
diff --git a/src/pminfo/GNUmakefile b/src/pminfo/GNUmakefile
@@ -37,6 +37,3 @@ $(EXT_FILES):
 	$(LN_S) $(TOPDIR)/src/external/$@ .
 
 pminfo.o:	$(TOPDIR)/src/include/pcp/libpcp.h $(EXT_FILES)
-
-check:: $(CFILES)
-	$(CLINT) $^
diff --git a/src/pmjson/GNUmakefile b/src/pmjson/GNUmakefile
@@ -32,6 +32,3 @@ install_pcp : install
 
 pmjson.o:	$(TOPDIR)/src/include/pcp/libpcp.h
 pmjson.o:	$(TOPDIR)/src/include/pcp/pmjson.h
-
-check:: $(CFILES)
-	$(CLINT) $^