Repository navigation
feat(deps): allow ignoring known-broken upstream releases - #6665
Merged
Merged
Conversation
check_upstream_version now skips a dep's latest release if it's listed in .external_versions/<dep>.ignore, so the update workflow stops re-proposing a version known to be broken until upstream ships a newer one. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…versions Replace the .external_versions/<dep>.ignore file approach with a lookup against GitHub's own PR history: closing a rejected version's update PR with the "wontfix" label is enough for check_upstream_version to recognize it later, since the closed PR's head branch name (which GitHub keeps even after the branch is deleted) encodes dep + version. No repo state to commit or keep in sync. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
gh already does head-branch + label filtering server-side, and reads GITHUB_TOKEN for auth automatically - no need to derive owner/repo from the git remote URL by hand or build the API request manually. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Same rationale as the PR-history check: gh already handles auth and request building. Drops the last curl+jq usage, so the separate "Install jq" step in the workflow is dead weight - removed. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#6642(bump coursier to v2.1.25) failed CI: the v2.1.25 standalone launcher jar is broken upstream, throwingNoSuchMethodError: cats.Align cats.implicits$.catsStdInstancesForList()on every command (bundles a mismatchedcats). See coursier/coursier#3865 — fixed upstream but not yet in a tagged release. Closed with thewontfixlabel.check_upstream_versionnow checks GitHub's own PR history before proposing a version: it queriesGET /repos/{owner}/{repo}/pulls?head=update/<dep>/<version>&state=closedand skips the version if a matching closed PR is labeledwontfix. GitHub keeps a PR's head branch name even after the branch is deleted, so this needs no file or state committed to the repo — closing a bad-version PR with that label is the whole mechanism.update_deps.yml's "Check for update" step now passesGITHUB_TOKENso the query is authenticated against our own repo.Test plan
./utils/check_upstream_version coursierreturns nothing (finds closed+wontfix-labeled Update coursier to v2.1.25 #6642 forupdate/coursier/v2.1.25)update/coursier/v2.1.24, unrelated close) isn't treated as rejected./utils/check_upstream_version metalsunaffected