Skip to content

feat(deps): allow ignoring known-broken upstream releases #6665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
perrin4869 merged 4 commits into from
Sep 23, 2026
Merged

feat(deps): allow ignoring known-broken upstream releases #6665

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ca517f7
feat(deps): allow ignoring known-broken upstream releases
perrin4869 Sep 23, 2026
9d501df
feat(deps): query PR history instead of a repo file to skip rejected …
perrin4869 Sep 23, 2026
16f766e
refactor(deps): use gh pr list instead of hand-rolled curl+jq
perrin4869 Sep 23, 2026
c185f91
refactor(deps): use gh api for the upstream release lookup too
perrin4869 Sep 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions .github/workflows/update_deps.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,10 @@ jobs:
steps:
- uses: actions/checkout@v7

- name: Install jq
uses: awalsh128/cache-apt-pkgs-action@latest
with:
packages: jq

- name: Check for update
id: check
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
new_version="$(utils/check_upstream_version "${{ matrix.dep }}")"
if [[ -n "$new_version" ]]; then
Expand Down
20 changes: 15 additions & 5 deletions utils/check_upstream_version
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,20 +20,30 @@ github_repo() {
esac
}

# A version we've deliberately rejected (e.g. a broken upstream release) gets
# its update PR closed with the "wontfix" label instead of merged. Checking
# for that PR - by its branch name, which GitHub keeps even after the branch
# itself is deleted - lets us skip re-proposing it without committing
# anything to the repo.
was_rejected() {
dep="$1"
version="$2"

count="$(gh pr list --state closed --head "update/$dep/$version" --label wontfix --json number --jq 'length' 2>/dev/null)" || return 1
[ "${count:-0}" -gt 0 ]
}

if [ ! -f "$VERSION_FILE" ]; then
echo "Missing version file for $DEP" >&2
exit 1
fi

REPO="$(github_repo "$DEP")"

LATEST="$(
curl -fsSL "https://api.github.com/repos/$REPO/releases/latest" \
| jq -r '.tag_name'
)"
LATEST="$(gh api "repos/$REPO/releases/latest" --jq '.tag_name')"

CURRENT="$(cat "$VERSION_FILE")"

if [ "$LATEST" != "$CURRENT" ]; then
if [ "$LATEST" != "$CURRENT" ] && ! was_rejected "$DEP" "$LATEST"; then
printf '%s\n' "$LATEST"
fi
Loading