Skip to content

Conversation

@carrvo
Copy link

@carrvo carrvo commented Mar 5, 2025

Overhead for creating a debian package.

This should help in acheiving #60

Comment on lines +30 to +31
debian-package-dependencies:
sudo apt install build-essential fakeroot devscripts apxs apache2-dev
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may not be appropriate but was included in case the Debian packaging dependencies are not well-known by the developers of this project.

Comment on lines +36 to +37
debian-package:
debuild --rootcmd=sudo --no-tgz-check -us -uc
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally elevating with sudo should be replaced with instructions for debian/rules so that it builds to the appropriate directory.

@@ -0,0 +1,25 @@
libapache2-mod-authnz-external (3.3.2-2) unstable; urgency=medium
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will want to add another entry before submitting package (added convenient make debian-package-version version=x.x.x for this purpose).

@@ -0,0 +1,58 @@
This package was debianized for Ubuntu by Chuck Short <[email protected]> on
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This copyright should be reviewed to ensure that it is current.

This package was debianized for Debian by Hai Zaar <[email protected]> on
Tue, 31 Mar 2009 18:32:20 +0300 based on the work mentioned above.

It was downloaded from http://code.google.com/p/mod-auth-external
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an outdated URL.

Suggested change
It was downloaded from http://code.google.com/p/mod-auth-external
It was downloaded from https://github.com/phokz/mod-auth-external

@@ -0,0 +1,30 @@
Source: libapache2-mod-authnz-external
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be reviewed for correctness. Especially for the maintainers.

@carrvo
Copy link
Author

carrvo commented Mar 7, 2025

This has been moved to carrvo/debian-libapache2-mod-authnz-external#1

@carrvo carrvo closed this Mar 7, 2025
@bimimicah
Copy link
Collaborator

bimimicah commented Mar 7, 2025

This has been moved to carrvo/debian-libapache2-mod-authnz-external#1


I added some comments/review here as you requested. Would you like me to add them to the new location?


Also, as mentioned in my comments above, I've now split out the LICENSE file to make it easy to just ship it with the built package (to make it easier for you to satisfy Apache 1.0 license requirements)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants