Parsing aliases in docblocks also #331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlessandroMinoccheri
force-pushed
the
alias-docblock
branch
from
6b56599 to
80cd452
Compare
AlessandroMinoccheri
changed the title
AlessandroMinoccheri
force-pushed
the
alias-docblock
branch
2 times, most recently
from
8308c7e to
a0c0d41
Compare
AlessandroMinoccheri
changed the title
fain182
requested changes
Jan 3, 2023
|
|
||
| $violations = new Violations(); | ||
|
|
||
| $notHaveDependencyOutsideNamespace = new DependsOnlyOnTheseNamespaces('MyProject\AppBundle\Application'); |
There was a problem hiding this comment.
The variable name is slightly wrong, but maybe we can test it more directly without using a rule?
src/Analyzer/NameResolver.php
Outdated
| } | ||
|
|
||
| if (null === $node->type) { | ||
| if (null === $node->type || !($node->type instanceof FullyQualified)) { |
There was a problem hiding this comment.
You can remove the null === $node->type because is already in the second clause of the OR....
There was a problem hiding this comment.
Good catch! Fixed!
AlessandroMinoccheri
force-pushed
the
alias-docblock
branch
from
a0c0d41 to
d787ea6
Compare
fain182
approved these changes
Jan 3, 2023
micheleorselli
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should solve problem 1 of this issue #307 about aliases