Remove deprecated field from Deployment #5809
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagnik3788
requested review from
khanhtc1202,
ffjlabo,
t-kikuc and
Warashi
as code owners
Signed-off-by: sagnik3788 <[email protected]>
|
@sagnik3788 |
Signed-off-by: sagnik3788 <[email protected]>
Signed-off-by: sagnik3788 <[email protected]>
|
I will fix these |
khanhtc1202
changed the title
|
@sagnik3788 Please fix lint and test, and use |
Signed-off-by: sagnik3788 <[email protected]>
t-kikuc
requested changes
May 16, 2025
Signed-off-by: sagnik3788 <[email protected]>
Warashi
reviewed
May 22, 2025
| @@ -77,7 +77,6 @@ var ( | |||
| d.StatusReason = statusReason | |||
| d.RunningCommitHash = runningCommitHash | |||
| d.RunningConfigFilename = runningConfigFilename | |||
| d.Version = version | |||
There was a problem hiding this comment.
Please remove the argument version because it is unused now.
|
@sagnik3788 And please fix the conflict 🙇 It's due to other PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
as title
Why we need it:
version field was already marked as deprecated and is no longer in use
Which issue(s) this PR fixes:
Fixes #5061