Remove deprecated field from Deployment

pkg/app/piped/controller/scheduler.go

@@ -816,7 +816,6 @@ func (s *scheduler) reportMostRecentlySuccessfulDeployment(ctx context.Context)
 				DeploymentId:   s.deployment.Id,
 				Trigger:        s.deployment.Trigger,
 				Summary:        s.deployment.Summary,
-				Version:        s.deployment.Version,
 				Versions:       s.deployment.Versions,
 				ConfigFilename: s.deployment.GitPath.GetApplicationConfigFilename(),
 				StartedAt:      s.deployment.CreatedAt,

pkg/app/piped/trigger/deployment.go

@@ -121,7 +121,6 @@ func reportMostRecentlyTriggeredDeployment(ctx context.Context, client apiClient
 				DeploymentId: d.Id,
 				Trigger:      d.Trigger,
 				Summary:      d.Summary,
-				Version:      d.Version,
 				Versions:     d.Versions,
 				StartedAt:    d.CreatedAt,
 				CompletedAt:  d.CompletedAt,

pkg/app/pipedv1/controller/scheduler.go

@@ -793,7 +793,6 @@ func (s *scheduler) reportMostRecentlySuccessfulDeployment(ctx context.Context)
 				DeploymentId:   s.deployment.Id,
 				Trigger:        s.deployment.Trigger,
 				Summary:        s.deployment.Summary,
-				Version:        s.deployment.Version,
 				Versions:       s.deployment.Versions,
 				ConfigFilename: s.deployment.GitPath.GetApplicationConfigFilename(),
 				StartedAt:      s.deployment.CreatedAt,

pkg/app/pipedv1/trigger/deployment.go

@@ -119,7 +119,6 @@ func reportMostRecentlyTriggeredDeployment(ctx context.Context, client apiClient
 			DeploymentId: d.Id,
 			Trigger:      d.Trigger,
 			Summary:      d.Summary,
-			Version:      d.Version,
 			Versions:     d.Versions,
 			StartedAt:    d.CreatedAt,
 			CompletedAt:  d.CompletedAt,

pkg/datastore/deploymentstore.go

@@ -77,7 +77,6 @@ var (
 			d.StatusReason = statusReason
 			d.RunningCommitHash = runningCommitHash
 			d.RunningConfigFilename = runningConfigFilename
-			d.Version = version
 			d.Versions = versions
 			d.Stages = stages
 			return nil

pkg/datastore/deploymentstore_test.go

@@ -83,7 +83,6 @@ func TestDeploymentToPlannedUpdater(t *testing.T) {
 	assert.Equal(t, expectedStatusDesc, d.StatusReason)
 	assert.Equal(t, expectedRunningCommitHash, d.RunningCommitHash)
 	assert.Equal(t, expectedRunningConfigFilename, d.RunningConfigFilename)
-	assert.Equal(t, expectedVersion, d.Version)
 	assert.Equal(t, expectedVersions, d.Versions)
 	assert.Equal(t, expectedStages, d.Stages)
 }

pkg/model/deployment.proto

@@ -57,7 +57,7 @@ enum StageStatus {
 // - User clicked on Sync button at application web page.
 // - Triggered by another deployment.
 message Deployment {
-    reserved 4;
+    reserved 4,23;
 
     // The generated unique identifier.
     string id = 1 [(validate.rules).string.min_len = 1];
@@ -91,8 +91,7 @@ message Deployment {
     // e.g. Scale from 10 to 100 replicas.
     // e.g. Update image from v1.5.0 to v1.6.0.
     string summary = 22;
-    // TODO: Remove version from deployment model.
-    string version = 23;
+
     repeated ArtifactVersion versions = 24;
 
     // Hash value of the most recently successfully deployed commit.

web/model/deployment_pb.d.ts

@@ -48,9 +48,6 @@ export class Deployment extends jspb.Message {
   getSummary(): string;
   setSummary(value: string): Deployment;
 
-  getVersion(): string;
-  setVersion(value: string): Deployment;
-
   getVersionsList(): Array<pkg_model_common_pb.ArtifactVersion>;
   setVersionsList(value: Array<pkg_model_common_pb.ArtifactVersion>): Deployment;
   clearVersionsList(): Deployment;
@@ -122,7 +119,6 @@ export namespace Deployment {
     labelsMap: Array<[string, string]>,
     trigger?: DeploymentTrigger.AsObject,
     summary: string,
-    version: string,
     versionsList: Array<pkg_model_common_pb.ArtifactVersion.AsObject>,
     runningCommitHash: string,
     runningConfigFilename: string,

web/src/__fixtures__/dummy-deployment.ts

@@ -21,7 +21,6 @@ export const dummyDeployment: Deployment.AsObject = {
   status: DeploymentStatus.DEPLOYMENT_SUCCESS,
   statusReason: "good",
   trigger: dummyTrigger,
-  version: "0.0.0",
   versionsList: [],
   cloudProvider: "kube-1",
   platformProvider: "kube-1",
@@ -65,7 +64,6 @@ export function createDeploymentFromObject(o: Deployment.AsObject): Deployment {
   deployment.setStatusReason(o.statusReason);
   deployment.setSummary(o.summary);
   deployment.setUpdatedAt(o.updatedAt);
-  deployment.setVersion(o.version);
   o.gitPath && deployment.setGitPath(createGitPathFromObject(o.gitPath));
   o.trigger && deployment.setTrigger(createTriggerFromObject(o.trigger));
   o.stagesList &&