Switch to using a fixed mmseqs binaries for clustering#103
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on standardizing the MMseqs2 binaries used for clustering operations by updating the relevant package dependency. This ensures that all clustering processes utilize a consistent and specified version of the MMseqs2 software, improving reliability and reproducibility. Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the version of the @platforma-open/soedinglab.software-mmseqs2 package from 1.18.0 to 1.18.2. The changes are consistent with the pull request's goal of using a specific version of the mmseqs binaries. I have one suggestion regarding versioning consistency in pnpm-workspace.yaml to improve long-term maintainability.
| '@milaboratories/software-pframes-conv': ^2.2.9 | ||
| '@platforma-open/milaboratories.runenv-python-3': ^1.7.3 | ||
| '@platforma-open/soedinglab.software-mmseqs2': 1.18.0 | ||
| '@platforma-open/soedinglab.software-mmseqs2': 1.18.2 |
There was a problem hiding this comment.
While this change correctly updates the pinned version of @platforma-open/soedinglab.software-mmseqs2, I notice that other dependencies in this 'Block-specific dependencies' section use caret ^ version ranges (e.g., lines 25-28). For consistency and to prevent potential dependency issues, it would be beneficial to either pin all block-specific dependencies or use a version range for this one as well, if appropriate. If pinning is required for mmseqs2 specifically, adding a comment to explain why would be helpful for future maintenance.
No description provided.