Skip to content

Switch to using a fixed mmseqs binaries for clustering#103

Open
mzueva wants to merge 1 commit into
mainfrom
mzueva/use-fixed-mmseqs
Open

Switch to using a fixed mmseqs binaries for clustering#103
mzueva wants to merge 1 commit into
mainfrom
mzueva/use-fixed-mmseqs

Conversation

@mzueva

@mzueva mzueva commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on standardizing the MMseqs2 binaries used for clustering operations by updating the relevant package dependency. This ensures that all clustering processes utilize a consistent and specified version of the MMseqs2 software, improving reliability and reproducibility.

Highlights

  • MMseqs2 Binary Update: The version of the @platforma-open/soedinglab.software-mmseqs2 package has been updated from 1.18.0 to 1.18.2 across the project's dependency configurations.
  • Changelog Entry Added: A new changeset file (.changeset/salty-cats-pay.md) was added to document the update to the fixed MMseqs2 binaries for clustering.
Changelog
  • .changeset/salty-cats-pay.md
    • Added a new changeset file documenting the MMseqs2 binary update.
  • pnpm-lock.yaml
    • Updated the version of @platforma-open/soedinglab.software-mmseqs2 from 1.18.0 to 1.18.2.
    • Refreshed the integrity hash for the updated mmseqs2 package.
  • pnpm-workspace.yaml
    • Updated the catalog specifier for @platforma-open/soedinglab.software-mmseqs2 to version 1.18.2.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the version of the @platforma-open/soedinglab.software-mmseqs2 package from 1.18.0 to 1.18.2. The changes are consistent with the pull request's goal of using a specific version of the mmseqs binaries. I have one suggestion regarding versioning consistency in pnpm-workspace.yaml to improve long-term maintainability.

Comment thread pnpm-workspace.yaml
'@milaboratories/software-pframes-conv': ^2.2.9
'@platforma-open/milaboratories.runenv-python-3': ^1.7.3
'@platforma-open/soedinglab.software-mmseqs2': 1.18.0
'@platforma-open/soedinglab.software-mmseqs2': 1.18.2

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While this change correctly updates the pinned version of @platforma-open/soedinglab.software-mmseqs2, I notice that other dependencies in this 'Block-specific dependencies' section use caret ^ version ranges (e.g., lines 25-28). For consistency and to prevent potential dependency issues, it would be beneficial to either pin all block-specific dependencies or use a version range for this one as well, if appropriate. If pinning is required for mmseqs2 specifically, adding a comment to explain why would be helpful for future maintenance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant