Skip to content

Switch to using a fixed mmseqs binaries for clustering #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mzueva wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Switch to using a fixed mmseqs binaries for clustering #103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/salty-cats-pay.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@platforma-open/milaboratories.clonotype-clustering": patch
---

Switch to using a fixed mmseqs binaries for clustering
12 changes: 6 additions & 6 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pnpm-workspace.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ catalog:
'@milaboratories/multi-sequence-alignment': '^1.46.5'
'@milaboratories/software-pframes-conv': ^2.2.9
'@platforma-open/milaboratories.runenv-python-3': ^1.7.3
'@platforma-open/soedinglab.software-mmseqs2': 1.18.0
'@platforma-open/soedinglab.software-mmseqs2': 1.18.2

@gemini-code-assist gemini-code-assist Bot Mar 12, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While this change correctly updates the pinned version of @platforma-open/soedinglab.software-mmseqs2, I notice that other dependencies in this 'Block-specific dependencies' section use caret ^ version ranges (e.g., lines 25-28). For consistency and to prevent potential dependency issues, it would be beneficial to either pin all block-specific dependencies or use a version range for this one as well, if appropriate. If pinning is required for mmseqs2 specifically, adding a comment to explain why would be helpful for future maintenance.


# Common dependencies - can use ^ or ~
'vue': ^3.5.24
Expand Down
Loading