Skip to content

Use pendulum if it's installed#978

Draft
masipcat wants to merge 1 commit intomasterfrom
pendulum-parser
Draft

Use pendulum if it's installed#978
masipcat wants to merge 1 commit intomasterfrom
pendulum-parser

Conversation

@masipcat
Copy link
Copy Markdown
Contributor

@masipcat masipcat commented Jun 11, 2020

Close #974
Sadly, I found we can't use it: python-pendulum/pendulum#305

Copy link
Copy Markdown
Member

@vangheem vangheem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@masipcat
Copy link
Copy Markdown
Contributor Author

This can't be merged right now because of this python-pendulum/pendulum#305
We could consider using https://github.com/closeio/ciso8601 instead of pendulum or just add a entry in the documentation explaining how to overwrite the default deserializer with another library.

Maybe we could add a configuration entry to especify the path of the datetime parser functions, so it can be customized.

Copy link
Copy Markdown
Member

@bloodbare bloodbare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking forward be able to merge it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Question] Datetime deserialization format

3 participants