Skip to content

Use pendulum if it's installed #978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
masipcat wants to merge 1 commit into
base: master
Choose a base branch
from
+15 −1
Draft

Use pendulum if it's installed #978

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ CHANGELOG
6.0.0b6 (unreleased)
--------------------

- Use pendulum's parser to deserialize datetime values (if it's installed).
Otherwise use current one. [masipcat]

- Undo datetime object renderization on
guillotina_json_default. [lferran]

Expand Down
13 changes: 12 additions & 1 deletion guillotina/json/deserialize_value.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,16 @@
# -*- coding: utf-8 -*-
from dateutil.parser import parse

try:
# Pendulum's parser is faster than dateutil.parser for dates with format
# RFC 3339/ISO 8601. See GH issue #974 for details.
from pendulum.parsing import parse as _parse
from functools import partial

# When parse is called with `strict=False` it calls dateutil.parse() as fallback
parse = partial(_parse, strict=False)
except ImportError:
from dateutil.parser import parse

from guillotina import configure
from guillotina.component import ComponentLookupError
from guillotina.component import get_adapter
Expand Down