Repository navigation
Describe the depth camera generically, not as an OAK-D (docs, messages, env var) - #27
Merged
Merged
Conversation
The Orbbec Gemini 305 is the default depth camera, yet comments, docs, log
messages and check labels still described every recording as an OAK-D's.
Reword them in terms of "the depth camera" (the dcam_ files are already
named that way), and say which behaviour depends on an IMU.
- READMEs: intro, data flow, SLAM description and Hardware section list the
Gemini 305 (default, no IMU) and the OAK-D SR.
- User-visible strings: the Space's sync message, check labels, recording
check messages ("oak imu: ..." -> "imu: ...", matching "imu: none").
- VSLAM_BINARY replaces OAK_VSLAM_BINARY (set in the Dockerfile, read by
pipeline.py; renamed together, so the Space is unaffected).
No identifier, file, directory or Docker image is renamed here: those wait
for feat/tactile-sensing, #5 and #23 to land. Lines inside their hunks
(app.py, dataset.py, oak_slam.py, trajectory.py, checks/tags.py,
checks/trajectory.py, pipeline.py:433) are left alone. Legacy oakd_* names
stay: old recordings still use them.
Assisted-by: Claude:claude-opus-5-5
This was referenced Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #26: the base is
postprocess-consolidation, so the diff shows only this change. When #26 merges, change the base todevelop(GitHub does it automatically if #26's branch is deleted on merge).The Orbbec Gemini 305 is the default depth camera (
depth_camera = "gemini305"in grabette's config), but the post-processing still described every recording as an OAK-D's. This PR is the prose-only step of the OAK → generic cleanup.What changes
READMEs (root +
grabette-postprocess/): the intro, data flow and SLAM description now say "depth camera" and spell out what depends on an IMU (visual-inertial with the OAK-D SR, visual-only with the Gemini 305). The Hardware section lists both cameras plus the RPi fisheye.Docstrings / comments in
checks/sync.py,checks/recording.py,checks/__init__.py,convert.py,pipeline.pyand the CLI scripts.User-visible strings:
OAK cam↔gyro lag→depth-cam ↔ gyro lagOAK-left ↔ OAK-gyro→depth-cam left ↔ gyrooak imu: …→imu: …, matching the existingimu: nonelineNo code or test matches on any of these strings.
Env var:
OAK_VSLAM_BINARY→VSLAM_BINARY. It's set in theDockerfileand read inpipeline.py, renamed together, so the Space behaves the same.Deliberately not in this PR
oak_slam.py,run_oak_slam(),check_oak_imu(),convert_episode_to_oak.py, theoak/intermediate dir,docker/oak_vslam/, theoak_dirvariables): these wait forfeat/tactile-sensing, casquette: raw camera-only pass-through in the multi-arm build #5 and 22 modify the threshold for trajectory check #23 to land, so they don't hand those branches a painful rebase.pollenrobotics/oak-vslam→pollenrobotics/grabette-vslam: needs a Docker Hub push first, and goes with the code renames.app.py:84andpipeline.py:433, plus everything indataset.py,oak_slam.py,trajectory.py,checks/tags.pyandchecks/trajectory.py.oakd_*file names and their tests (old recordings still use them), the IMU/OAK-D-specific notes inchecks/recording.py, the measurement notes incompare_trajectories.py, the DepthAI attribution, and the"oak"RTAB-Map camera label inoffline_vslam.cpp.Verification
pytest: 67 passed.pyfile compiles.--helpruns forcheck_sync.py,check_dataset.py,visualize_rgbd_trajectory.py(with--extra viz) andrun_oak_slam.py.feat/tactile-sensing, casquette: raw camera-only pass-through in the multi-arm build #5 or 22 modify the threshold for trajectory check #23 in the library,app.pyorviews.py. The edits inpipeline.pyandDockerfileare outside their hunks.ENVname, read bypipeline.pyin the same commit.🤖 Generated with Claude Code