fix: close selected preview on single click #848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
set context_page to preview with Some(entity) instead of None when "Show details" is selected. Preview of None entity would fail first equality check in Message::ToggleContextPage as `Preview(None, ..) != Preview(Some, ..)` . This fixes the two clicks needed to close Preview of Selected as first click would update self.context_page from Preview(None,..) to Preview(Some,..) and next click would pass equality and close Preview.
This reverts commit b25d0b5.
match on Preview (the type) to close preview context in single click. matching on Preview type prevents the equality check failing b/w ContextPage::Preview(Some,_) and ContextPage::Preview(None,_)
jackpot51
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #834
Use
matches!to compare b/wContextPage::Previewas first pressing on "Close" button would fail the equality check b/wPreview(None, _)andPreview(Some(entity),_).This fixes the two clicks needed to close Preview of Selected as first click would update
self.context_pagefromPreview(None,..)toPreview(Some,..)and next click would pass equality and close Preview.EDIT: prev. implementation was changing
self.context_pagefrom None to Some inPreviewwhich fixed the original issue, but the persist preview would still require two clicks to close.Newer commit fixes original issue + fixes two clicks required on persisted preview as well.