refactor: Restrict aria roles by element type

[rschristian]

Starting to take a look at #3853, seems role restriction should be simple enough for most elements. Spec Doc

Edit: Unfortunately there's some rare situations in which the spec should be ignored which presents an issue here: adding stricter types might dissuade people against using the correct role on some elements because the spec (and therefore our types) don't allow it. I'd like to guess that this occurs far less often than a user simply reaching for the wrong roles, however, hence this PR.

---

There are some roles that we can't limit via types, mainly due to descendant restrictions ("If not a descendant of <article>, <aside>, <main>, ..., etc.) or specific attribute values ("If size attribute is greater than 1"), but this does get most elements/roles.

With this I think I'm all typed out for the foreseeable future 😅

[coveralls]

coverage: 99.615%. remained the same
when pulling f66acff on refactor/aria-role-subset
into bb68456 on main.

[rschristian]

When an incorrect role is applied, if we're restricting via more complex intersection types, our Signalish helper seems to cause error messages to blow up if the particular intersection key can be found on the base interface.

This isn't an issue in all cases, but to be somewhat consistent, I've stripped these from the base interfaces. Take the following example:

<input type="checkbox" role="slider" /> // I'm invalid!

With type?: Signalish<HTMLInputTypeAttribute | undefined> set, you get this error:

Type '{ type: "checkbox"; role: "slider"; }' is not assignable to type 'InputHTMLAttributes<HTMLInputElement>'.
  Types of property 'type' are incompatible.
    Type '"checkbox"' is not assignable to type '(Signalish<HTMLInputTypeAttribute | undefined> & Signalish<"button">) | (Signalish<HTMLInputTypeAttribute | undefined> & Signalish<...>) | (Signalish<...> & Signalish<...>) | (Signalish<...> & Signalish<...>) | (Signalish<...> & Signalish<...>)'. (tsserver 2322)

Without, you get this:

Type '{ type: "checkbox"; role: "slider"; }' is not assignable to type 'InputHTMLAttributes<HTMLInputElement>'.
  Types of property 'type' are incompatible.
    Type '"checkbox"' is not assignable to type 'Signalish<"button"> | Signalish<"image"> | Signalish<"range"> | Signalish<"reset"> | Signalish<"submit">'. (tsserver 2322)

Not an expert here, but the latter is a lot better.

[rschristian]

Partial... might be a poor name, very much open to suggestions.

[rschristian]

Worth calling out, we can't quite adhere to this spec but might be better than nothing. Can also just revert too, treat it like others we can't support via types and just allow any aria role.

[JoviDeCroock]

@rschristian Let's target this one at v11-2 as well

[rschristian]

Worried it might be breaking? I have no strong opinion either way, though with how verbose this is, it might make v11 look a bit messier.

[JoviDeCroock]

This should allow us to close out the #3853 issue I reckon

[rschristian]

Hm, I don't think so.

While this does take a big first step, it's limited to aria roles; it does not attempt to provide (restricted) types for any of the myriad of other aria attributes that are available.

[rschristian]

Going to merge, everything seems good!