-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the flow-over-heated-plate for nearest-projection #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MakisH
reviewed
Mar 12, 2021
flow-over-heated-plate-nearest-projection/fluid-openfoam/0.orig/T
Outdated
Show resolved
Hide resolved
flow-over-heated-plate-nearest-projection/fluid-openfoam/run.sh
Outdated
Show resolved
Hide resolved
flow-over-heated-plate-nearest-projection/fluid-openfoam/system/preciceDict
Show resolved
Hide resolved
flow-over-heated-plate-nearest-projection/solid-openfoam/run.sh
Outdated
Show resolved
Hide resolved
MakisH
approved these changes
Mar 22, 2021
Co-authored-by: Gerasimos Chourdakis <[email protected]>
davidscn
added a commit
that referenced
this pull request
Mar 23, 2021
* Add the flow-over-heated-plate for nearest-projection * Remove OpenFOAM merch header * Remove OpenFOAM merch header pt 2 * Update run.sh script documentation * Move parts from this tutorial to the adapter docs * Update flow-over-heated-plate-nearest-projection/README.md Co-authored-by: Gerasimos Chourdakis <[email protected]> Co-authored-by: Gerasimos Chourdakis <[email protected]> Co-authored-by: Gerasimos Chourdakis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #136 and as discussed there.
This is a first draft version which has all functionality. However, the README was previously rather tied to the OpenFOAM case. Therefore I would like to hear the opinion of @MakisH which parts to move in the adapter docs and which parts to keep here in the tutorials. We could of course also keep as it is since we only have OpenFOAM at the moment.