-
Notifications
You must be signed in to change notification settings - Fork 70
Refactor Nulecule params #442
base: master
Are you sure you want to change the base?
Conversation
Fixes projectatomic#423. Date: Fri Dec 04 15:30:39 2015 +0530
- bugfix for not updating values for params in config with static value.
ed716c1
to
e478688
Compare
@kanarip @dustymabe @vpavlin @cdrage |
@rtnpro a lot of tests fail, we'll have to have compatibility from putting params both under |
I have not looked at the code at all but have looked at the POC code in projectatomic/nulecule-library#30. This looks interesting and I am going through and going to try to convert my etherpad app to do the same thing and see what all I need to change. @cdrage. Do you mind looking at this in detail and also consider the work you did for xpathing when you review? Start with projectatomic/nulecule-library#30 and then we can both look at the code in this PR. |
One thing I noticed when playing around with this is that only parts of the config are getting passed to the provider. An example is that if I put 'providerconfig' into the answers.conf file it does not make it into the provider code. The |
@vpavlin @dustymabe @cdrage @kadel @goern So, I updated the POC for refactoring params in Nulecule spec here: It allows: Cross referencing paramsThis allows referencing params definition across sibling components in a Nulecule. It fixes duplicate param problem in answers or config data. Config mappingIt allows channelize config from current Nulecule to its external Nulecule children, or, local component according to their needs. This allows, optionally, in controlling access to config data to external Nulecule apps. The end result will be a cleaner and understandable answers file, where users enter However, this will not take the freedom of overriding config data for a Nulecule component at any level in the Nulecule tree by adding a section for it in |
@rtnpro I looked at your sentry example and it seems like there is a lot of mixing of ideas in there, which is probably a mistake. Do you mind adding your new proposal to https://gist.github.com/rtnpro/17add2ab248ac34a7687 so it can clearly be evaluated? |
Woo! projectatomic/nulecule#196 has been merged, no more blockers @rtnpro |
@dustymabe @cdrage @surajssd @containscafeine |
Refactor Nulecule/atomicapp params to support developing nested Nulecule applications easy. This work is to fix the issues discussed in projectatomic/nulecule#187
Fixes #423.