This repository has been archived by the owner on Mar 22, 2018. It is now read-only.
[WIP]Sentry POC Nulecule app with refactored params #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtnpro
force-pushed
the
sentry-refactored-params
branch
from
8dfbdc0 to
42cd141
Compare
- Allow cross referencing params definition among sibling components, does not break any existing feature We no longer need to dump params in the global section for sharing it across components. Fixes duplicate params issue in answers.conf - Allow mapping config data for local as well as external apps, does not break any existing feature. Allows to pass data from the root Nulecule to all it's children.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains needed refactor in Nulecule SPEC file for sentry nulecule application to accommodate changes introduced by projectatomic/atomicapp#442