-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hamiltonian replica exchange #1128
Conversation
7dab71b
to
a5177ea
Compare
This reverts commit 037bf9f75086014fb585649af1b09d177e94c2b1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 -- nice!
Only nits in this pass, will attempt some tire-kicking before completing review.
* handle < ncols states * don't draw axes for empty subplots
* call ctxt.multiple_steps directly for equilibration * factor out get_context
K^4 is impractical for more than ~20 windows
@maxentile I added a nightly benchmark in 33f0e72. This currently just prints ns per day estimates for sequential and HREX simulations for vacuum, solvent, and complex legs with 5, 10, and 20 windows. (More than 20 is difficult to run in a reasonable time with the restriction that we keep the ratio of MD to HREX swap moves constant) |
For much less than this, overhead of context creation becomes significant
Adds a generic implementation of Hamiltonian replica exchange (HREX) and a specialized version for use with RBFE implemented using the former.
Notes
run_leg
functions).To do
Example plots
Test system: evenly-spaced overlapping Gaussians