-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FE: fix KC action DELETE to EDIT #4181
base: master
Are you sure you want to change the base?
Conversation
Kudos, SonarCloud Quality Gate passed!
|
@@ -138,7 +138,7 @@ const Actions: React.FC = () => { | |||
danger | |||
permission={{ | |||
resource: ResourceType.CONNECT, | |||
action: Action.DELETE, | |||
action: Action.EDIT, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why should a DELETE
operation have and EDIT
action ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are 4 actions for KC now. VIEW
, EDIT
, CREATE
, RESTART
.
i think DELETE
is some kind of WRITE operation (comepare to READ), so i assigned a EDIT
action to deleting a KC.
maybe later, DELETE
will be removed from EDIT
and be it's own action. (and also PAUSE, RESUME... )
but for now, the button does not work. so if it has to be fixed within 4 actions, EDIT
is appropriate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is my patch related to this one? I added DELETE action to BE, so I am just not sure if I addressed this case (do not remember): #4250. |
What changes did you make? (Give an overview)

in spite of all permission for KC(Kafka Connect), i cannot delete connect KC in each page. (image)
because the component has 'DELETE' action which is not in KC action list now, so i changed it to 'EDIT'
i also got the next plan for RBAC #4170, but i think this is a issue that needs to be fixed for current use
thank you for your review. 😃
Is there anything you'd like reviewers to focus on?
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)
Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)
Check out Contributing and Code of Conduct
A picture of a cute animal (not mandatory but encouraged)