Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FE: fix KC action DELETE to EDIT #4181

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

p-eye
Copy link
Contributor

@p-eye p-eye commented Aug 31, 2023

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
스크린샷 2023-08-30 오후 5 27 53
in spite of all permission for KC(Kafka Connect), i cannot delete connect KC in each page. (image)
because the component has 'DELETE' action which is not in KC action list now, so i changed it to 'EDIT'

i also got the next plan for RBAC #4170, but i think this is a issue that needs to be fixed for current use
thank you for your review. 😃

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@p-eye p-eye requested a review from a team as a code owner August 31, 2023 23:47
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@@ -138,7 +138,7 @@ const Actions: React.FC = () => {
danger
permission={{
resource: ResourceType.CONNECT,
action: Action.DELETE,
action: Action.EDIT,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why should a DELETE operation have and EDIT action ?

Copy link
Contributor Author

@p-eye p-eye Sep 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are 4 actions for KC now. VIEW, EDIT, CREATE, RESTART.
i think DELETE is some kind of WRITE operation (comepare to READ), so i assigned a EDIT action to deleting a KC.
maybe later, DELETE will be removed from EDIT and be it's own action. (and also PAUSE, RESUME... )
but for now, the button does not work. so if it has to be fixed within 4 actions, EDIT is appropriate.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oldium
Copy link

oldium commented Dec 5, 2023

Is my patch related to this one? I added DELETE action to BE, so I am just not sure if I addressed this case (do not remember): #4250.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants