Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FE: fix KC action DELETE to EDIT #4181

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

FE: fix KC action DELETE to EDIT #4181

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion kafka-ui-react-app/src/components/Connect/Details/Actions/Actions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ const Actions: React.FC = () => {
danger
permission={{
resource: ResourceType.CONNECT,
action: Action.DELETE,
action: Action.EDIT,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why should a DELETE operation have and EDIT action ?

Copy link
Contributor Author

@p-eye p-eye Sep 7, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are 4 actions for KC now. VIEW, EDIT, CREATE, RESTART.
i think DELETE is some kind of WRITE operation (comepare to READ), so i assigned a EDIT action to deleting a KC.
maybe later, DELETE will be removed from EDIT and be it's own action. (and also PAUSE, RESUME... )
but for now, the button does not work. so if it has to be fixed within 4 actions, EDIT is appropriate.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Haarolean ?

value: routerProps.connectorName,
}}
>
Expand Down