octoprint: Fix serial output from chamber power to expected chamber temp format by bkerler · Pull Request #4671 · prusa3d/Prusa-Firmware-Buddy

bkerler · 2025-05-28T06:42:31Z

This changes the C@: output which shall be used for chamber power only to C:x.x/m.m where x is current chamber temp and m is target chamber temp in order to match the expected behaviour, see reference. Also separated from chamber power define to allow chamber temp being used if chamber api and chamber temp is supported, even if chamber power isn't defined.

As HAS_HEATER_CHAMBER and HAS_TEMP_CHAMBER are old Merlin defines and HAS_CHAMBER_API() is used in favor, we prioritize HAS_CHAMBER_API for now until the old Merlin code has been removed.

ulab · 2025-05-28T07:03:12Z

I am not an expert on these values, but does software expect it to be in the form C:1.0/0.0 where 1.0 is the current chamber temp and 0.0 the target temp?

All other temperatures seem to be in that format.

Recv: T:230.00/230.00 B:60.02/60.00 X:37.45/36.00 A:48.65/0.00 @:137 B@:73 C@:31.61 HBR@:255

https://reprap.org/wiki/G-code#M105:_Get_Extruder_Temperature seems to be a little vague on this:

A temperature report will usually include actual and target temperature for all available heaters, with the format being "actual/target" or - for some firmware variants - "actual /target". During a blocking heatup some firmware variants only report the temperature tuple for the heater that is currently in blocking heatup state.

The ambient temperature is being reported as A:48.65/0.00 too and it hopefully doesn't have a target temp set by the printer ;-).

bkerler · 2025-05-28T07:16:20Z

@ulab Good point, thanks ! I've changed the PR to reflect the expected format.

bkerler · 2025-05-28T07:17:53Z

The format seems to accept both C:49.3 and C:49.3/39.3 .... but as we already have a function to get the target chamber temperature, it does sound right to also add it to be parsed :)

CZDanol · 2025-05-28T10:47:00Z

lib/Marlin/Marlin/src/module/temperature.cpp

      auto current_chamber_temperature = buddy::chamber().current_temperature();
-      if (current_chamber_temperature.has_value()) SERIAL_ECHOPAIR(" C@:", current_chamber_temperature.value());
+      auto target_chamber_temperature = buddy::chamber().target_temperature();
+      if (current_chamber_temperature.has_value()) SERIAL_ECHOPAIR(" C:", current_chamber_temperature.value(), "/", target_chamber_temperature.value());


Do you think ECHOPAIR will work with four parameters?

Yes, at least there are several codelines using multiple arguments (see binary_protocol.h, line 170).
But for readability, I've now split it up to two SERIAL_ECHOPAIR :)

CZDanol · 2025-05-28T10:47:31Z

lib/Marlin/Marlin/src/module/temperature.cpp

      auto current_chamber_temperature = buddy::chamber().current_temperature();
-      if (current_chamber_temperature.has_value()) SERIAL_ECHOPAIR(" C@:", current_chamber_temperature.value());
+      auto target_chamber_temperature = buddy::chamber().target_temperature();
+      if (current_chamber_temperature.has_value()) SERIAL_ECHOPAIR(" C:", current_chamber_temperature.value(), "/", target_chamber_temperature.value());


Not checking whether target_chamber_temperature has value

Absolutely right. Fixed that.

CZDanol · 2025-05-28T13:13:08Z

lib/Marlin/Marlin/src/module/temperature.cpp

+      auto target_chamber_temperature = buddy::chamber().target_temperature();
+      if (current_chamber_temperature.has_value()){
+        SERIAL_ECHOPAIR(" C:", current_chamber_temperature.value());
+        SERIAL_ECHOPAIR("/", target_chamber_temperature.has_value() ? target_chamber_temperature.value() : 0.0f);


There is std::optional::value_or. In that case, you don't even need to store target_chamber_temperature into a separate variable

Cool :) Thanks for the tip !

CZDanol · 2025-05-28T13:14:06Z

lib/Marlin/Marlin/src/module/temperature.cpp

      auto current_chamber_temperature = buddy::chamber().current_temperature();
-      if (current_chamber_temperature.has_value()) SERIAL_ECHOPAIR(" C@:", current_chamber_temperature.value());
+      auto target_chamber_temperature = buddy::chamber().target_temperature();
+      if (current_chamber_temperature.has_value()){


Nitpick/tip: You can do if(auto temp = buddy::chamber().current_temperature())

TLMcNulty · 2025-06-05T01:53:46Z

Would love to see this merged and released! In discussion with some octo contributors it looks good.

graelo · 2025-08-16T20:06:30Z

Hi, thanks for this work!
I'm curious about why this PR isn't making progress anymore, can you share? Oh, by the way, unfortunately we currently can't access the Jenkins logs.

graelo · 2025-08-19T21:25:03Z

Thank you @bkerler ❤️

3d-gussner · 2025-08-21T08:10:59Z

Oh, by the way, unfortunately we currently can't access the Jenkins logs.

FYI: Jenkins has been disabled on public PRs.

3d-gussner · 2025-09-30T12:34:52Z

@bkerler Can you please check if that hasn't been implemented in 6.4.0-alpha or 6.4.0-rc?

bkerler · 2025-09-30T13:42:29Z

Sure ! Will have a look

BlueFyre · 2025-09-30T17:36:54Z

The RC seems to still have the old one:

Prusa-Firmware-Buddy/lib/Marlin/Marlin/src/module/temperature.cpp

Line 3012 in 9b4e96e

    
           if (current_chamber_temperature.has_value()) SERIAL_ECHOPAIR(" C@:", current_chamber_temperature.value());

bkerler · 2025-10-03T14:18:53Z

@3d-gussner as @BlueFyre correctly already stated, the RC still does have the old behaviour and thus isn't fixed.

3d-gussner · 2025-10-06T07:57:53Z

@bkerler @BlueFyre Thanks for reviewing, forwarded the information to the developers.

ruebarb · 2025-12-05T18:27:20Z

Same issue for C1L

…d target temperature

bkerler mentioned this pull request May 28, 2025

[BFW-6788] [BUG] Core One has no CHAMBER_TEMPERATURE capability and does not report C temperature #4479

Open

bkerler force-pushed the fix_chamber_temp branch from 9e0b45c to a389b6b Compare May 28, 2025 07:15

bkerler changed the title ~~octoprint: Fix serial output from chamber power to chamber temp parameter~~ octoprint: Fix serial output from chamber power to expected chamber temp format May 28, 2025

CZDanol reviewed May 28, 2025

View reviewed changes

bkerler force-pushed the fix_chamber_temp branch from a389b6b to 4209499 Compare May 28, 2025 10:57

bkerler requested a review from CZDanol May 28, 2025 11:00

CZDanol reviewed May 28, 2025

View reviewed changes

bkerler force-pushed the fix_chamber_temp branch from 4209499 to af7cf95 Compare May 28, 2025 15:06

bkerler requested a review from CZDanol May 28, 2025 15:08

bkerler force-pushed the fix_chamber_temp branch 3 times, most recently from af2baa1 to fbb6a03 Compare May 29, 2025 10:05

BlueFyre mentioned this pull request Sep 12, 2025

[BFW-7717][BUG] Prusa XL w/ Enclosure reports 0C temperature #4800

Open

danopernis force-pushed the master branch from 77255c9 to b91eeda Compare November 26, 2025 12:42

Fix serial output from chamber power to chamber temp parameter and ad…

b2763c4

…d target temperature

bkerler force-pushed the fix_chamber_temp branch from f5020fd to b2763c4 Compare December 7, 2025 14:46

Conversation

bkerler commented May 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ulab commented May 28, 2025

Uh oh!

bkerler commented May 28, 2025

Uh oh!

bkerler commented May 28, 2025

Uh oh!

CZDanol May 28, 2025

Choose a reason for hiding this comment

Uh oh!

bkerler May 28, 2025

Choose a reason for hiding this comment

Uh oh!

CZDanol May 28, 2025

Choose a reason for hiding this comment

Uh oh!

bkerler May 28, 2025

Choose a reason for hiding this comment

Uh oh!

CZDanol May 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bkerler May 28, 2025

Choose a reason for hiding this comment

Uh oh!

CZDanol May 28, 2025

Choose a reason for hiding this comment

Uh oh!

bkerler May 28, 2025

Choose a reason for hiding this comment

Uh oh!

TLMcNulty commented Jun 5, 2025

Uh oh!

graelo commented Aug 16, 2025

Uh oh!

graelo commented Aug 19, 2025

Uh oh!

3d-gussner commented Aug 21, 2025

Uh oh!

3d-gussner commented Sep 30, 2025

Uh oh!

bkerler commented Sep 30, 2025

Uh oh!

BlueFyre commented Sep 30, 2025

Uh oh!

bkerler commented Oct 3, 2025

Uh oh!

3d-gussner commented Oct 6, 2025

Uh oh!

ruebarb commented Dec 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

bkerler commented May 28, 2025 •

edited

Loading

CZDanol May 28, 2025 •

edited

Loading