Skip to content

Conversation

confused-Techie
Copy link
Member

This PR tracks and displays locale load times in timecop for both Pulsar's own locales, and each package's locales.

This adds two new variables:

  • atom.localeLoadTime: A variable on the atom global, that says how many milliseconds it took to load Pulsar's own locales.
  • <package>.loadTime:locales: A variable on every single package, that says how many milliseconds it took to load that package's locales.

The additions in timecop look like this:

image

And use all available standards and practices in timecop to make it's addition as seamless as possible. Let me know what you think!

@confused-Techie
Copy link
Member Author

I've removed the package locale loading from timecop due to requests on Discord. Now leaving the menu looking like so:

image

But I am still leaving the metrics within the packages metadata, in case we want to inspect it at a later time

Copy link
Member

@DeeDeeG DeeDeeG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonably done to me, at a glance?

@confused-Techie
Copy link
Member Author

Thanks for the approval @DeeDeeG, in reality this is a rather simple PR to allow some monitoring of locales, just to ensure nothing gets too out of wack

@confused-Techie confused-Techie merged commit ca0e976 into master Sep 30, 2025
103 checks passed
@confused-Techie confused-Techie deleted the locale-stats branch September 30, 2025 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants