Skip to content

[core & timecop] Locale loading Statistics #1338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 30, 2025
Merged

[core & timecop] Locale loading Statistics #1338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d16a7d1
Add core locale loading time as `atom.localeLoadTime`
confused-Techie Sep 14, 2025
c18b900
Add `loadTime:locales` as load time for every package
confused-Techie Sep 14, 2025
003987a
Display core and package load time in `timecop`
confused-Techie Sep 14, 2025
7679752
Remove package locale load time from `timecop`
confused-Techie Sep 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions packages/timecop/lib/window-panel-view.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ export default class WindowPanelView {
this.disposables.add(atom.tooltips.add(this.refs.windowTiming, {title: 'The time taken to load this window'}))
this.disposables.add(atom.tooltips.add(this.refs.projectTiming, {title: 'The time taken to rebuild the previously opened buffers'}))
this.disposables.add(atom.tooltips.add(this.refs.workspaceTiming, {title: 'The time taken to rebuild the previously opened editors'}))
this.disposables.add(atom.tooltips.add(this.refs.localeTiming, {title: 'The time taken to load core locales'}))
}

update () {}
Expand Down Expand Up @@ -49,6 +50,12 @@ export default class WindowPanelView {
<span className='inline-block' ref='workspaceLoadTime'>Loading…</span>
</div>
</div>

<div className='timing' ref='localeTiming'>
<span className='inline-block'>Locale load time</span>
<span className='inline-block' ref='localeLoadTime'>Loading…</span>
</div>

</div>
</div>
</div>
Expand Down Expand Up @@ -77,6 +84,10 @@ export default class WindowPanelView {
} else {
this.refs.deserializeTimings.style.display = 'none'
}

const localeLoadTime = atom.localeLoadTime;
this.refs.localeLoadTime.classList.add(this.getHighlightClass(localeLoadTime))
this.refs.localeLoadTime.textContent = `${localeLoadTime}ms`
}

getHighlightClass (time) {
Expand Down
2 changes: 2 additions & 0 deletions src/atom-environment.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,10 +109,12 @@ class AtomEnvironment {
});

/** @type {I18n} */
const localeLoadStartTime = performance.now();
this.i18n = new I18n({
config: this.config
});
this.i18n.preload();
this.localeLoadTime = Math.round(performance.now() - localeLoadStartTime);

/** @type {KeymapManager} */
this.keymaps = new KeymapManager({
Expand Down
48 changes: 25 additions & 23 deletions src/package.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -534,35 +534,37 @@ module.exports = class Package {
}

loadLocales() {
if (this.bundledPackage && this.packageManager.packagesCache[this.name]) {
for (const localePath in this.packageManager.packagesCache[this.name].locales) {
const localeFilePathSplit = localePath.split(".");
const locale = localeFilePathSplit[localeFilePathSplit.length - 2] ?? "";
if (atom.i18n.shouldIncludeLocale(locale)) {
const localeFile = this.packageManager.packagesCache[this.name].locales[localePath];
const localeObj = {};
localeObj[this.name] = localeFile;
atom.i18n.addStrings(localeObj, locale);
}
}
} else {
const localesDirPath = path.join(this.path, "locales");
const localesPaths = fs.listSync(localesDirPath, ["cson", "json"]);

for (const localePath of localesPaths) {
const localeFilePath = localePath.split(".");
// `package-name.en-US.json` => `en-US`
const locale = localeFilePath[localeFilePath.length - 2] ?? "";
if (atom.i18n.shouldIncludeLocale(locale)) {
const localeFile = CSON.readFileSync(localePath);
if (localeFile) {
this.measure('loadTime:locales', () => {
if (this.bundledPackage && this.packageManager.packagesCache[this.name]) {
for (const localePath in this.packageManager.packagesCache[this.name].locales) {
const localeFilePathSplit = localePath.split(".");
const locale = localeFilePathSplit[localeFilePathSplit.length - 2] ?? "";
if (atom.i18n.shouldIncludeLocale(locale)) {
const localeFile = this.packageManager.packagesCache[this.name].locales[localePath];
const localeObj = {};
localeObj[this.name] = localeFile;
atom.i18n.addStrings(localeObj, locale);
}
}
} else {
const localesDirPath = path.join(this.path, "locales");
const localesPaths = fs.listSync(localesDirPath, ["cson", "json"]);

for (const localePath of localesPaths) {
const localeFilePath = localePath.split(".");
// `package-name.en-US.json` => `en-US`
const locale = localeFilePath[localeFilePath.length - 2] ?? "";
if (atom.i18n.shouldIncludeLocale(locale)) {
const localeFile = CSON.readFileSync(localePath);
if (localeFile) {
const localeObj = {};
localeObj[this.name] = localeFile;
atom.i18n.addStrings(localeObj, locale);
}
}
}
}
}
});
}

getKeymapPaths() {
Expand Down
Loading