Update Rubocop #9222
Merged
Update Rubocop #9222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhashizume
force-pushed
the
maint/main/rubocop-update
branch
from
f475e8d to
17a8e46
Compare
mhashizume
force-pushed
the
maint/main/rubocop-update
branch
from
17a8e46 to
66e0759
Compare
This commit removes an unnecessary require statement of pp, which is a default Gem. This offense was identified by the Rubocop Lint/RedundantRequireStatement cop.
Prior to this commit, Rubocop was configured to use Ruby 2.5 syntax and all Rubocop-related gems were pinned to the last version to support Ruby 2.5. This was carried over from the Puppet 7 series, which specifies Ruby 2.5 as its minimum Ruby version. This commit sets Rubocop's TargetRubyVersion to 3.1, the same as the minimum Ruby version set in Puppet 8's gemspec. Additionally, this commit relaxes all Rubocop-related gem version specifiers in the Gemfile to allow for newer versions of the gems.
Ruby 2.6 introduced endless ranges. This commit updates all ranges that ended at -1 to instead by endless. This issue was identified by the Rubocop Style/SlicingWithRange cop.
mhashizume
force-pushed
the
maint/main/rubocop-update
branch
from
66e0759 to
b00d968
Compare
joshcooper
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates Rubocop, its extensions, and the TargetRubyVersion to reflect that Puppet 8's minimum required Ruby version is 3.1.
Additionally, this PR addresses any new Rubocop offenses that this update causes.