Skip to content

Feature/798 add edit modal - #832

Draft
schiltpuzzle wants to merge 5 commits into
mainfrom
feature/798-add-edit-modal
Draft

Feature/798 add edit modal#832
schiltpuzzle wants to merge 5 commits into
mainfrom
feature/798-add-edit-modal

Conversation

@schiltpuzzle

Copy link
Copy Markdown
Collaborator

No description provided.

@schiltpuzzle schiltpuzzle self-assigned this Aug 25, 2026
@schiltpuzzle
schiltpuzzle marked this pull request as draft August 25, 2026 14:13
@schiltpuzzle schiltpuzzle linked an issue Aug 25, 2026 that may be closed by this pull request
3 tasks
@github-actions

Copy link
Copy Markdown

Migration Test Results

35 tests   35 ✅  3s ⏱️
10 suites   0 💤
10 files     0 ❌

Results for commit eec3e52.

@github-actions

Copy link
Copy Markdown

Frontend Test Results

  1 files   54 suites   33s ⏱️
307 tests 288 ✅ 0 💤 19 ❌
310 runs  291 ✅ 0 💤 19 ❌

For more details on these failures, see this check.

Results for commit eec3e52.

@schiltpuzzle

schiltpuzzle commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator Author

PR Status — 25.08.2026

Reminder: Understand the goal first, then work on it.

Done

  • When clicking a row the modal opens with the right component selected.
  • Some of the data is prefilled, but some are still missing.

ToDos

  • Fill out drop-down data. At the moment the drop-down data is not being filled.
  • Update the titles so they match the modal mode.

@github-actions

Copy link
Copy Markdown

Backend Test Results

766 tests   766 ✅  58s ⏱️
 66 suites    0 💤
 66 files      0 ❌

Results for commit eec3e52.

@schiltpuzzle

Copy link
Copy Markdown
Collaborator Author

PR Status — 01.09.2026

Reminder: Understand the goal first, then work on it.

The row click should return a event that is past up to the Memberdetailview via angular output. GenericTable -> GenericContent -> MemberDetailView

The model should not be fetched in the modal it should be fetch onSubmitMethod that is given to the createDialogOpener:

  openDegreeDialog = this.modalService.createDialogOpener<DegreeModel>(
    AddDegreeComponent, this.member, (model: DegreeModel) => { 
//should be called right here 
this.degreeService.addDegree(model)}, () => this.memberResource.reload(), [ModalSubmitMode.ENTER_ANOTHER,
      ModalSubmitMode.COPY]
  );

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Technical Story: Add Edit Modal

1 participant