Skip to content

Conversation

grace-sng7
Copy link
Collaborator

No description provided.

grace-sng7 and others added 16 commits May 18, 2025 20:30
Signed-off-by: Grace Sng <[email protected]>
Signed-off-by: Grace Sng <[email protected]>
Signed-off-by: Grace Sng <[email protected]>
Copy link
Member

@amit-sharma amit-sharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR @grace-sng7 I've shared a few inline comments.

I also notice that the build is failing. I'm working on a fix and will update this PR.

@grace-sng7
Copy link
Collaborator Author

@amit-sharma

Hi Dr. Sharma, thanks for the comments. I've added a few updates to the PR.

Copy link
Member

@amit-sharma amit-sharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @grace-sng7 I just have one comment for the notebook.

@grace-sng7 grace-sng7 requested a review from amit-sharma June 28, 2025 05:09
Copy link
Member

@amit-sharma amit-sharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @grace-sng7 The new edits remove the installation errors. Merging. ..

@amit-sharma amit-sharma merged commit 6476b90 into main Jun 28, 2025
4 checks passed
@amit-sharma amit-sharma deleted the creating_augmented_suggester branch June 28, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants