Skip to content

Conversation

swolchok
Copy link
Contributor

@swolchok swolchok commented Sep 4, 2025

Description

#5824 looks like it might simply be the first PR where windows-latest means windows-2025. checking to see if CI is broken on main..

@rwgk
Copy link
Collaborator

rwgk commented Sep 4, 2025

Ugh ... I just sunk a few hours into #5822 ... barely 2 days later this. Sigh.

@henryiii Maybe it'll be better to avoid latest in general, and modernize in a more controlled fashion, like we pin almost everything else?

@swolchok Could you please try systematically replacing all windows-latest with windows-2022 in .github/workflows/ci.yml, and if needed also in configure.yml and pip.yml?

@swolchok
Copy link
Contributor Author

swolchok commented Sep 5, 2025

@swolchok Could you please try systematically replacing all windows-latest with windows-2022 in .github/workflows/ci.yml, and if needed also in configure.yml and pip.yml?

done, skipped configure.yml for the first pass #5826

@henryiii
Copy link
Collaborator

henryiii commented Sep 5, 2025

The images are not static. There’s no way to pin, they all get updated regularly. An old ones get dropped pretty quickly, less than a year warning. So I think using latest is fine unless we need something specific.

@swolchok swolchok closed this Sep 5, 2025
@swolchok swolchok deleted the kick-ci branch September 5, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants