Skip to content

Conversation

swolchok
Copy link
Contributor

@swolchok swolchok commented Sep 5, 2025

Description

Per request from @rwgk: #5825 (comment)

@rwgk
Copy link
Collaborator

rwgk commented Sep 5, 2025

Awesome, thanks!

@henryiii
Copy link
Collaborator

henryiii commented Sep 5, 2025

LGTM, but we will need to understand why latest fails by the time 2022 is dropped. It hit EoL nearly a month ago.

@henryiii henryiii merged commit 852a4b5 into pybind:master Sep 5, 2025
85 checks passed
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Sep 5, 2025
@swolchok
Copy link
Contributor Author

swolchok commented Sep 5, 2025

why latest fails

ChatGPT suggested experimenting with flushing the relevant streams explicitly FWIW

@rwgk rwgk removed the needs changelog Possibly needs a changelog entry label Sep 5, 2025
rwgk added a commit to rwgk/pybind11 that referenced this pull request Sep 12, 2025
rwgk added a commit that referenced this pull request Sep 13, 2025
* Revert "s/windows-2022/windows-latest/ in .github/workflows/{ci,pip}.yml (#5826)"

This reverts commit 852a4b5.

* Add module-level skip for Windows build >= 26100 in test_iostream.py

* Changes suggested by at-henryiii
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants