Skip to content

Conversation

@Kludex
Copy link
Member

@Kludex Kludex commented Dec 18, 2025

Note

Introduces repository-wide large file enforcement via pre-commit.

  • Adds check-added-large-files with --maxkb=1024 and --enforce-all to scan the entire repo
  • Excludes tests/models/cassettes/*, tests/cassettes/*, uv.lock, and tests/assets/kiwi.png from the size check

Written by Cursor Bugbot for commit 29a48a2. This will update automatically on new commits. Configure here.

@Kludex Kludex enabled auto-merge (squash) December 18, 2025 11:04
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is being reviewed by Cursor Bugbot

Details

You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

- id: check-added-large-files
args:
- --maxkb=1024 # 1MB
- --enforce-all # Allow to run in the whole source code, instead of only the changed files.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Invalid --enforce-all flag for check-added-large-files hook

The --enforce-all argument is not a valid option for the check-added-large-files hook from pre-commit/pre-commit-hooks. This hook only accepts --maxkb to set the maximum file size. The stated goal of running on the whole source code instead of just changed files won't be achieved because this flag doesn't exist. When the hook runs, it will either fail with an unrecognized argument error or silently ignore the flag, neither achieving the intended behavior.

Fix in Cursor Fix in Web

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's why I'm moving to VSCode.

@github-actions
Copy link

github-actions bot commented Dec 18, 2025

Docs Preview

commit: 29a48a2
Preview URL: https://37b6b5b7-pydantic-ai-previews.pydantic.workers.dev

@Kludex
Copy link
Member Author

Kludex commented Dec 18, 2025

3 hours waiting to have a timeout. :(

@Kludex Kludex merged commit 27a17c6 into main Dec 23, 2025
30 checks passed
@Kludex Kludex deleted the enforce-large-file branch December 23, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants