Skip to content

Enforce size limit on the repository #3764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kludex merged 3 commits into from
Dec 23, 2025
+12 −0
Merged

Enforce size limit on the repository #3764

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
39cf93b
Enforce size limit on the repository
Kludex Dec 18, 2025
030a971
Add comment
Kludex Dec 18, 2025
29a48a2
Merge branch 'main' into enforce-large-file
Kludex Dec 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,18 @@ repos:
- id: check-toml
- id: end-of-file-fixer
- id: trailing-whitespace
- id: check-added-large-files
args:
- --maxkb=1024 # 1MB
- --enforce-all # Allow to run in the whole source code, instead of only the changed files.
Copy link

@cursor cursor bot Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Invalid --enforce-all flag for check-added-large-files hook

The --enforce-all argument is not a valid option for the check-added-large-files hook from pre-commit/pre-commit-hooks. This hook only accepts --maxkb to set the maximum file size. The stated goal of running on the whole source code instead of just changed files won't be achieved because this flag doesn't exist. When the hook runs, it will either fail with an unrecognized argument error or silently ignore the flag, neither achieving the intended behavior.

Fix in Cursor Fix in Web

Copy link
Member Author

@Kludex Kludex Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's why I'm moving to VSCode.

# TODO(Marcelo): We should replace the kiwi.png file with a smaller one.
exclude: |
(?x)^(
tests/models/cassettes/.*|
tests/cassettes/.*|
uv.lock|
tests/assets/kiwi.png
)$

- repo: https://github.com/sirosen/texthooks
rev: 0.6.8
Expand Down
Loading