-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Update pyproject toml and relock deps #3778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Fix `outlines-transformers` and `outlines-vllm-offline` markers to use `sys_platform == 'linux'` since vllm/torch only have Linux wheels - Remove outdated `python_version < '3.12'` restriction from vllm (vllm 0.10.0+ supports Python 3.12+) - Add `vllm>=0.10.0` minimum version to ensure proper wheel availability - Add `[tool.uv.environments]` to restrict lockfile resolution to Linux and macOS platforms (excludes Windows which has no wheels) - Regenerate uv.lock with updated dependencies The previous marker `(sys_platform != 'darwin' or platform_machine != 'x86_64')` incorrectly included macOS ARM64 and Windows, causing uv to fall back to ancient vllm versions (0.1.3) that require CUDA to build from source. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
pyproject.toml
Outdated
| environments = [ | ||
| "sys_platform == 'linux' and platform_machine == 'x86_64'", | ||
| "sys_platform == 'linux' and platform_machine == 'aarch64'", | ||
| "sys_platform == 'darwin' and platform_machine == 'arm64'", | ||
| "sys_platform == 'darwin' and platform_machine == 'x86_64'", | ||
| ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we have this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason claude gave is mistaken, please revert this one.
pydantic_ai_slim/pyproject.toml
Outdated
| bedrock = ["boto3>=1.40.14"] | ||
| huggingface = ["huggingface-hub[inference]>=0.33.5,<1.0.0"] | ||
| outlines-transformers = ["outlines[transformers]>=1.0.0, <1.3.0; (sys_platform != 'darwin' or platform_machine != 'x86_64')", "transformers>=4.0.0", "pillow", "torch; (sys_platform != 'darwin' or platform_machine != 'x86_64')"] | ||
| outlines-transformers = ["outlines[transformers]>=1.0.0, <1.3.0; sys_platform == 'linux'", "transformers>=4.0.0", "pillow", "torch; sys_platform == 'linux'"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why did those change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, I got why we need this one, why do we need the environments?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I restablished this part because was getting a type error on the from outlines.models.transformers import from_transformers in tests/conftest.py
I guess if someone is contributing from a windows PC they'll also have that type error
Docs Preview
|
45ae500 to
23108ca
Compare
23108ca to
6a17930
Compare
outlines-transformersandoutlines-vllm-offlinemarkers to usesys_platform == 'linux'since vllm/torch only have Linux wheelspython_version < '3.12'restriction from vllm(vllm 0.10.0+ supports Python 3.12+)
vllm>=0.10.0minimum version to ensure proper wheel availability[tool.uv.environments]to restrict lockfile resolution toLinux and macOS platforms (excludes Windows which has no wheels)
The previous marker
(sys_platform != 'darwin' or platform_machine != 'x86_64')incorrectly included macOS ARM64 and Windows, causing uv to fall back to
ancient vllm versions (0.1.3) that require CUDA to build from source.
🤖 Generated with Claude Code
Co-Authored-By: Claude Opus 4.5 [email protected]