Skip to content

Conversation

@dsfaccini
Copy link
Collaborator

  • Fix outlines-transformers and outlines-vllm-offline markers to use
    sys_platform == 'linux' since vllm/torch only have Linux wheels
  • Remove outdated python_version < '3.12' restriction from vllm
    (vllm 0.10.0+ supports Python 3.12+)
  • Add vllm>=0.10.0 minimum version to ensure proper wheel availability
  • Add [tool.uv.environments] to restrict lockfile resolution to
    Linux and macOS platforms (excludes Windows which has no wheels)
  • Regenerate uv.lock with updated dependencies

The previous marker (sys_platform != 'darwin' or platform_machine != 'x86_64')
incorrectly included macOS ARM64 and Windows, causing uv to fall back to
ancient vllm versions (0.1.3) that require CUDA to build from source.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.5 [email protected]

- Fix `outlines-transformers` and `outlines-vllm-offline` markers to use
  `sys_platform == 'linux'` since vllm/torch only have Linux wheels
- Remove outdated `python_version < '3.12'` restriction from vllm
  (vllm 0.10.0+ supports Python 3.12+)
- Add `vllm>=0.10.0` minimum version to ensure proper wheel availability
- Add `[tool.uv.environments]` to restrict lockfile resolution to
  Linux and macOS platforms (excludes Windows which has no wheels)
- Regenerate uv.lock with updated dependencies

The previous marker `(sys_platform != 'darwin' or platform_machine != 'x86_64')`
incorrectly included macOS ARM64 and Windows, causing uv to fall back to
ancient vllm versions (0.1.3) that require CUDA to build from source.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>
pyproject.toml Outdated
Comment on lines 91 to 96
environments = [
"sys_platform == 'linux' and platform_machine == 'x86_64'",
"sys_platform == 'linux' and platform_machine == 'aarch64'",
"sys_platform == 'darwin' and platform_machine == 'arm64'",
"sys_platform == 'darwin' and platform_machine == 'x86_64'",
]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we have this?

Copy link
Member

@Kludex Kludex Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason claude gave is mistaken, please revert this one.

bedrock = ["boto3>=1.40.14"]
huggingface = ["huggingface-hub[inference]>=0.33.5,<1.0.0"]
outlines-transformers = ["outlines[transformers]>=1.0.0, <1.3.0; (sys_platform != 'darwin' or platform_machine != 'x86_64')", "transformers>=4.0.0", "pillow", "torch; (sys_platform != 'darwin' or platform_machine != 'x86_64')"]
outlines-transformers = ["outlines[transformers]>=1.0.0, <1.3.0; sys_platform == 'linux'", "transformers>=4.0.0", "pillow", "torch; sys_platform == 'linux'"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did those change?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I got why we need this one, why do we need the environments?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I restablished this part because was getting a type error on the from outlines.models.transformers import from_transformers in tests/conftest.py

I guess if someone is contributing from a windows PC they'll also have that type error

@github-actions
Copy link

github-actions bot commented Dec 19, 2025

Docs Preview

commit: 0e25361
Preview URL: https://f4376a92-pydantic-ai-previews.pydantic.workers.dev

@dsfaccini dsfaccini force-pushed the sync-and-relock-deps branch from 45ae500 to 23108ca Compare December 19, 2025 23:06
@dsfaccini dsfaccini force-pushed the sync-and-relock-deps branch from 23108ca to 6a17930 Compare December 19, 2025 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants