Conversation
Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>
On executor shutdown Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>
77edb16 to
38009e1
Compare
|
@liamhuber This should also work fine for 1.9.0 - as tested in #812 |
That's my hope. I just checked it out locally and am re-running the tests (sans SLURM), but it is not yet going nicely... |
Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>
|
Yeah, locally I'm getting |
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (50.00%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #816 +/- ##
==========================================
- Coverage 93.46% 93.36% -0.11%
==========================================
Files 38 38
Lines 3873 3873
==========================================
- Hits 3620 3616 -4
- Misses 253 257 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
In executorlib-1.8.2, which cancels futures when the executor is
.shutdown.This gets us into a recursive pickle when the
_finish_runcallback internall shuts down the executor. Passing that shutdown over to a separate, patient thread resolves all the issues in the local tests forexecutorlib-1.8.2. I need the CI to see if it also resolves the issue running with SLURM