feat: mp4upload provider, refactor, better mpv android support#1704
Conversation
Derisis13
left a comment
Derisis13
left a comment
There was a problem hiding this comment.
Amazing work, though a little pita to set up. I only ask for the new error to be changed and to consider a permanent warning (maybe with a link to the readme?)
|
Playback and downloadng work with the new providers, so PR is good if you push the warning |
|
tested and functioning as designed for pc, haven't tested on android |
|
works on android, as I tested it while implementing it. |
|
that's not how testing works, typically |
|
??? then how does testing work? |
|
am I in a backward land? developers don't catch everything, you need testers. a collaborator doesn't get to declare that their code works without someone else testing it |
|
Okay then, please test it on all platforms. 🙂 |
|
no? I don't have the time. you also don't get to decree when people volunteer their time |
|
Guys can we actually merge PR fixes and not leave them terminally open? Also someone pls merge #1663, I know things are evolving still, but we need some kind of visual indication that things aren't merely out-of-date, but actually broken. |
Derisis13
left a comment
Derisis13
left a comment
There was a problem hiding this comment.
I'm in favor of merging it, it'd be nice if we kept the language clean, but it's not a blocker. Just kind of low in my opinion.
|
I want to mention about mp4upload.
current state of providers
|
|
@port19x this is a "minor version" but maybe it'd be worth to do a release on it. What do you think? |
…bump) (#17) * docs: bump min version to 4.12 for packaging status (pystardust#1663) * feat: mp4upload provider, refactor, better mpv android support (pystardust#1704) Coolnsx (2026-05-23): > I want to mention about mp4upload. > Requires referrer and tls verify to none only works with mpv and mpv frontends like iina. VLC is not working with this provider. iSH plebs may suffer playback issues and the people that uses VLC to watch anime, sorry in advance. > current state of providers > sharepoint is unstable for past few weeks. youtube one is working, but it requires referrer. hianime is gone for good (the code for this is removed to rule out this provider) wixmp is only on old anime (anime that release before 2020 I guess). mp4upload requires that referrer and tls-verify to none. * test: cover new mp4upload provider paths from upstream b8032b7 Upstream's mp4upload refactor removed the sharepoint/hianime/wixmp/youtube provider functions and added an mp4upload branch. Existing bash unit tests no longer reach 10 lines of script that previously contributed to the pure-coverage ratchet (78 -> 68). Pins the new behavior: - select_quality's per-provider refr_flag dispatch (mp4upload sets a literal mp4upload.com referer; sharepoint unsets refr_flag; everything else falls back to allanime_refr). - cleanup() - new helper invoked on SIGINT and normal exit. - process_response() - replaces decode_tobeparsed; non-encrypted responses short-circuit through a pass-through path. - provider_init's new raw-value branch - triggered when the matched line does not start with `--` (mp4upload and youtube providers). Also aligns lefthook.yml's shellcheck invocation with the two-pass setup in .github/workflows/bash.yml. Lefthook previously ran a single flag-less `shellcheck {staged_files}`, which flagged SC2034 / SC2154 / SC2030 / SC2031 on every bats file (test-context noise from the loader's sourced-globals pattern, already suppressed in CI). With that mismatch no .bats file could be committed without LEFTHOOK=0 - now local mirrors CI. * test: cover get_links fast4speed.rsvp dispatch branch Closes the remaining coverage-ratchet gap (76 -> 78) after the previous test commit. The fast4speed.rsvp case is the cleanest of the new get_links branches to unit-test because it short-circuits before any curl, so the assertion is a pure string round-trip. --------- Co-authored-by: port19 <port19@port19.xyz> Co-authored-by: Tanveer Ahmed Ansari <ansari.tan20@gmail.com>
Just for sake of continuity, I ask that we bump the "major" version. |
… changes) (#23) * docs: bump min version to 4.12 for packaging status (pystardust#1663) * feat: mp4upload provider, refactor, better mpv android support (pystardust#1704) Coolnsx (2026-05-23): > I want to mention about mp4upload. > Requires referrer and tls verify to none only works with mpv and mpv frontends like iina. VLC is not working with this provider. iSH plebs may suffer playback issues and the people that uses VLC to watch anime, sorry in advance. > current state of providers > sharepoint is unstable for past few weeks. youtube one is working, but it requires referrer. hianime is gone for good (the code for this is removed to rule out this provider) wixmp is only on old anime (anime that release before 2020 I guess). mp4upload requires that referrer and tls-verify to none. * ci: re-run CI to pick up required-mirrors workflow (#24) --------- Co-authored-by: port19 <port19@port19.xyz> Co-authored-by: Tanveer Ahmed Ansari <ansari.tan20@gmail.com>
5 participants
Pull Request Template
Type of change
Description
ramble here
Checklist
-chistory and continue work-ddownloads work-ssyncplay works-qquality works-vvlc works-e(select episode) aka-r(range selection) works-Sselect index works--skipani-skip works--skip-titleani-skip title argument works--no-detachno detach works--exit-after-playauto exit after playing works--nextep-countdowncountdown to next ep works--duband regular (sub) mode both work-hhelp info is up to dateAdditional Testcases