Skip to content

Conversation

stealthycole
Copy link

This is just a slightly modified version of the azure_tenant backend that uses OID instead of sub claim as the UID. Allows admins to more-safely switch to a version of Azure SSO that uses OID.

Issue: #684

This is just a slightly modified version of the azure_tenant backend that uses OID instead of sub claim as the UID. Allows admins to more-safely switch to a version of Azure SSO that uses OID.

Issue: python-social-auth#684
Copy link

codecov bot commented Jun 23, 2025

Codecov Report

Attention: Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.

Project coverage is 77.64%. Comparing base (4765bae) to head (782eb7e).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
social_core/backends/azuread_oid.py 0.00% 19 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1183      +/-   ##
==========================================
- Coverage   77.78%   77.64%   -0.14%     
==========================================
  Files         352      353       +1     
  Lines       10865    10884      +19     
  Branches      489      489              
==========================================
  Hits         8451     8451              
- Misses       2234     2253      +19     
  Partials      180      180              
Flag Coverage Δ
unittests 77.64% <0.00%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nijel
Copy link
Member

nijel commented Jun 23, 2025

Can you please add tests and documentation to https://github.com/python-social-auth/social-docs?

@nijel nijel mentioned this pull request Jun 25, 2025
@stealthycole
Copy link
Author

I've added the doc update here: python-social-auth/social-docs#309. I don't see tests in social-docs, but I do see test in social-core. However, there is no test file for azuread_tenant, which this is based on. Any advice?

@nijel
Copy link
Member

nijel commented Jul 22, 2025

You can probably base on social_core/tests/backends/test_azuread.py or social_core/tests/backends/test_azuread_b2c.py, but I have no clue how much they do differ.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants