-
-
Notifications
You must be signed in to change notification settings - Fork 569
Feature/azure oid backend #1183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Feature/azure oid backend #1183
Conversation
This is just a slightly modified version of the azure_tenant backend that uses OID instead of sub claim as the UID. Allows admins to more-safely switch to a version of Azure SSO that uses OID. Issue: python-social-auth#684
Azure oid backend
for more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1183 +/- ##
==========================================
- Coverage 77.78% 77.64% -0.14%
==========================================
Files 352 353 +1
Lines 10865 10884 +19
Branches 489 489
==========================================
Hits 8451 8451
- Misses 2234 2253 +19
Partials 180 180
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Can you please add tests and documentation to https://github.com/python-social-auth/social-docs? |
I've added the doc update here: python-social-auth/social-docs#309. I don't see tests in social-docs, but I do see test in social-core. However, there is no test file for azuread_tenant, which this is based on. Any advice? |
You can probably base on |
This is just a slightly modified version of the azure_tenant backend that uses OID instead of sub claim as the UID. Allows admins to more-safely switch to a version of Azure SSO that uses OID.
Issue: #684