Fix test_connect_ipv6_addr.

[RatanShreshtha]

I have added a check in for ipv6 host in _build_tunnel_request and accordingly modify the target, is there a better way ?

[codecov]

Codecov Report

Merging #75 into bleach-spike will increase coverage by <.01%.
The diff coverage is 100%.

@@               Coverage Diff                @@
##           bleach-spike      #75      +/-   ##
================================================
+ Coverage         98.36%   98.37%   +<.01%     
================================================
  Files                30       30              
  Lines              1901     1905       +4     
================================================
+ Hits               1870     1874       +4     
  Misses               31       31

Impacted Files	Coverage Δ
src/urllib3/_async/connection.py	96.41% <100%> (+0.07%)	⬆️

[codecov]

Codecov Report

Merging #75 into bleach-spike will increase coverage by <.01%.
The diff coverage is 100%.

@@               Coverage Diff                @@
##           bleach-spike      #75      +/-   ##
================================================
+ Coverage         98.36%   98.37%   +<.01%     
================================================
  Files                30       30              
  Lines              1901     1905       +4     
================================================
+ Hits               1870     1874       +4     
  Misses               31       31

Impacted Files	Coverage Δ
src/urllib3/_async/connection.py	96.41% <100%> (+0.07%)	⬆️

[njsmith]

Looks like a good approach to me!

This is one of those classic ones...
Writing the patch: 10 minutes
Figuring out which patch to write: 10 hours

[njsmith]

I'd probably write it like:

    try:
        socket.inet_pton(socket.AF_INET6, host)
    except OSError:
        # Not a raw IPv6 address
        target = "%s:%d" % (host, port)
    else:
        # raw IPv6 address
        target = "[%s]:%d" % (host, port)

It doesn't make a big difference here, but it's a good habit in cases like this to only put the minimal stuff inside the try block, to make sure you don't catch any unexpected exceptions by accident.

[RatanShreshtha]

thanks it seem more readable to me.

[njsmith]

Hmm. I bet we're also going to need a similar check somewhere to set up the Host: header correctly when doing a regular (no-proxy) request to a raw IPv6 address...

[RatanShreshtha]

I will look where we need to set-up such check for Host: header.

[pquentin]

Hmm. I bet we're also going to need a similar check somewhere to set up the Host: header correctly when doing a regular (no-proxy) request to a raw IPv6 address...

That does not exist at all in the urllib3 tests currently, so maybe we can address this in a future pull request? I opened #87 to this effect