-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
gh-127146: Update test skips for Emscripten 4.0.1 #129375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-127146: Update test skips for Emscripten 4.0.1 #129375
Conversation
9c27f1f
to
e2a80f3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All makes sense; the only issue preventing merge is the RTD build failure... not sure what is going on there. I'll poke around and see what I can find out.
Dumb question, but can the Emscripten version be detected so as to skip based on that version? I think there's prior art for this for various other platforms. |
It almost certainly can be; but it will require the analog of |
We have def is_emscripten_lt(ver):
if not is_emscripten:
return False
ver_tuple = tuple(int(x) for x in ver.split("."))
return sys._emscripten_info.emscripten_version < ver_tuple and then put |
We'll eventually want to surface the version in platform for consistency, rather than the semi-private name on We could also consider making this a feature of |
PR emscripten-core/emscripten#23306 fixed stating pipes and will be released as part of Emscripten 4.0.2. I removed skips for various other testes that were fixed in 4.0.1 or earlier.