gh-63882: Implement some test_minidom tests
#132879
Open
+32
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please include the original patch author in a Co-authored-by trailer. |
Co-authored-by: Julian Gindi <[email protected]>
StanFromIreland
force-pushed
the
apply-patch
branch
from
e93be5b to
ec9c382
Compare
This comment was marked as resolved.
This comment was marked as resolved.
hugovk
reviewed
Apr 25, 2025
Co-authored-by: Hugo van Kemenade <[email protected]>
picnixz
reviewed
Apr 25, 2025
There was a problem hiding this comment.
I've added some comments concerning unlink but AFAIK, this is only used to break internal references within the DOM itself. Since the objects are either discarded at the end of the function or are small, you might also forget about calling .unlink. OTOH, we can be consistent with the existing tests and always call unlink in an addCleanup instead.
Co-authored-by: Bénédikt Tran <[email protected]>
StanFromIreland
commented
Apr 26, 2025
|
Question has been resolved. |
picnixz
approved these changes
Apr 26, 2025
|
@hugovk I'll actually let you write the commit message as I don't know how you want the original patch's author to be credited. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies: https://bugs.python.org/file33258/issue19683.patch
cc @terryjreedy @hugovk @picnixz